From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/vblank: Fixup and document timestamp update/read barriers Date: Thu, 16 Apr 2015 15:03:23 +0200 Message-ID: <20150416130323.GG5082@phenom.ffwll.local> References: <1429082222-20820-1-git-send-email-daniel.vetter@ffwll.ch> <552E60D4.3070307@hurleysoftware.com> <20150415173153.GA6092@phenom.ffwll.local> <552FAB7F.4040707@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTP id BA8916E38D for ; Thu, 16 Apr 2015 06:01:24 -0700 (PDT) Received: by wiun10 with SMTP id n10so96187411wiu.1 for ; Thu, 16 Apr 2015 06:01:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <552FAB7F.4040707@hurleysoftware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Hurley Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Daniel Vetter , Michel =?iso-8859-1?Q?D=E4nzer?= List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgMTYsIDIwMTUgYXQgMDg6MzA6NTVBTSAtMDQwMCwgUGV0ZXIgSHVybGV5IHdy b3RlOgo+IE9uIDA0LzE1LzIwMTUgMDE6MzEgUE0sIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBP biBXZWQsIEFwciAxNSwgMjAxNSBhdCAwOTowMDowNEFNIC0wNDAwLCBQZXRlciBIdXJsZXkgd3Jv dGU6Cj4gPj4gSGkgRGFuaWVsLAo+ID4+Cj4gPj4gT24gMDQvMTUvMjAxNSAwMzoxNyBBTSwgRGFu aWVsIFZldHRlciB3cm90ZToKPiA+Pj4gVGhpcyB3YXMgYSBiaXQgdG9vIG11Y2ggY2FyZ28tY3Vs dGVkLCBzbyBsZXRzIG1ha2UgaXQgc29saWQ6Cj4gPj4+IC0gdmJsYW5rLT5jb3VudCBkb2Vzbid0 IG5lZWQgdG8gYmUgYW4gYXRvbWljLCB3cml0ZXMgYXJlIGFsd2F5cyBkb25lCj4gPj4+ICAgdW5k ZXIgdGhlIHByb3RlY3Rpb24gb2YgZGV2LT52YmxhbmtfdGltZV9sb2NrLiBTd2l0Y2ggdG8gYW4g dW5zaWduZWQKPiA+Pj4gICBsb25nIGluc3RlYWQgYW5kIHVwZGF0ZSBjb21tZW50cy4gTm90ZSB0 aGF0IGF0b21pY19yZWFkIGlzIGp1c3QgYQo+ID4+PiAgIG5vcm1hbCByZWFkIG9mIGEgdm9sYXRp bGUgdmFyaWFibGUsIHNvIG5vIG5lZWQgdG8gYXVkaXQgYWxsIHRoZQo+ID4+PiAgIHJlYWQtc2lk ZSBhY2Nlc3Mgc3BlY2lmaWNhbGx5Lgo+ID4+Pgo+ID4+PiAtIFRoZSBiYXJyaWVycyBmb3IgdGhl IHZibGFuayBjb3VudGVyIHNlcWxvY2sgd2VyZW4ndCBjb21wbGV0ZTogVGhlCj4gPj4+ICAgcmVh ZC1zaWRlIHdhcyBtaXNzaW5nIHRoZSBmaXJzdCBiYXJyaWVyIGJldHdlZW4gdGhlIGNvdW50ZXIg cmVhZCBhbmQKPiA+Pj4gICB0aGUgdGltZXN0YW1wIHJlYWQsIGl0IG9ubHkgaGFkIGEgYmFycmll ciBiZXR3ZWVuIHRoZSB0cyBhbmQgdGhlCj4gPj4+ICAgY291bnRlciByZWFkLiBXZSBuZWVkIGJv dGguCj4gPj4+Cj4gPj4+IC0gQmFycmllcnMgd2VyZW4ndCBwcm9wZXJseSBkb2N1bWVudGVkLiBT aW5jZSBiYXJyaWVycyBvbmx5IHdvcmsgaWYKPiA+Pj4gICB5b3UgaGF2ZSB0aGVtIG9uIGJvdGhz IHNpZGVzIG9mIHRoZSB0cmFuc2FjdGlvbiBpdCdzIHBydWRlbnQgdG8KPiA+Pj4gICByZWZlcmVu Y2Ugd2hlcmUgdGhlIG90aGVyIHNpZGUgaXMuIFRvIGF2b2lkIGR1cGxpY2F0aW5nIHRoZQo+ID4+ PiAgIHdyaXRlLXNpZGUgY29tbWVudCAzIHRpbWVzIGV4dHJhY3QgYSBsaXR0bGUgc3RvcmVfdmJs YW5rKCkgaGVscGVyLgo+ID4+PiAgIEluIHRoYXQgaGVscGVyIGFsc28gYXNzZXJ0IHRoYXQgd2Ug ZG8gaW5kZWVkIGhvbGQKPiA+Pj4gICBkZXYtPnZibGFua190aW1lX2xvY2ssIHNpbmNlIGluIHNv bWUgY2FzZXMgdGhlIGxvY2sgaXMgYWNxdWlyZWQgYQo+ID4+PiAgIGZldyBmdW5jdGlvbnMgdXAg aW4gdGhlIGNhbGxjaGFpbi4KPiA+Pj4KPiA+Pj4gU3BvdHRlZCB3aGlsZSByZXZpZXdpbmcgYSBw YXRjaCBmcm9tIENocmlzIFdpbHNvbiB0byBhZGQgYSBmYXN0cGF0aCB0bwo+ID4+PiB0aGUgdmJs YW5rX3dhaXQgaW9jdGwuCj4gPj4+Cj4gPj4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiA+Pj4gQ2M6IE1hcmlvIEtsZWluZXIgPG1hcmlvLmtsZWluZXIuZGVA Z21haWwuY29tPgo+ID4+PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+Pj4gQ2M6IE1pY2hlbCBEw6RuemVyIDxtaWNoZWxAZGFlbnplci5uZXQ+ Cj4gPj4+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwu Y29tPgo+ID4+PiAtLS0KPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMgfCA5MiArKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4+PiAgaW5jbHVk ZS9kcm0vZHJtUC5oICAgICAgICB8ICA4ICsrKy0tCj4gPj4+ICAyIGZpbGVzIGNoYW5nZWQsIDU0 IGluc2VydGlvbnMoKyksIDQ2IGRlbGV0aW9ucygtKQo+ID4+Pgo+ID4+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPiA+ Pj4gaW5kZXggYzhhMzQ0NzY1NzBhLi4yM2JmYmM2MWE0OTQgMTAwNjQ0Cj4gPj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPiA+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9p cnEuYwo+ID4+PiBAQCAtNzQsNiArNzQsMzMgQEAgbW9kdWxlX3BhcmFtX25hbWVkKHZibGFua29m ZmRlbGF5LCBkcm1fdmJsYW5rX29mZmRlbGF5LCBpbnQsIDA2MDApOwo+ID4+PiAgbW9kdWxlX3Bh cmFtX25hbWVkKHRpbWVzdGFtcF9wcmVjaXNpb25fdXNlYywgZHJtX3RpbWVzdGFtcF9wcmVjaXNp b24sIGludCwgMDYwMCk7Cj4gPj4+ICBtb2R1bGVfcGFyYW1fbmFtZWQodGltZXN0YW1wX21vbm90 b25pYywgZHJtX3RpbWVzdGFtcF9tb25vdG9uaWMsIGludCwgMDYwMCk7Cj4gPj4+ICAKPiA+Pj4g K3N0YXRpYyB2b2lkIHN0b3JlX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgY3J0 YywKPiA+Pj4gKwkJCSB1bnNpZ25lZCB2YmxhbmtfY291bnRfaW5jLAo+ID4+PiArCQkJIHN0cnVj dCB0aW1ldmFsICp0X3ZibGFuaykKPiA+Pj4gK3sKPiA+Pj4gKwlzdHJ1Y3QgZHJtX3ZibGFua19j cnRjICp2YmxhbmsgPSAmZGV2LT52YmxhbmtbY3J0Y107Cj4gPj4+ICsJdTMyIHRzbG90Owo+ID4+ PiArCj4gPj4+ICsJYXNzZXJ0X3NwaW5fbG9ja2VkKCZkZXYtPnZibGFua190aW1lX2xvY2spOwo+ ID4+PiArCj4gPj4+ICsJaWYgKHRfdmJsYW5rKSB7Cj4gPj4+ICsJCXRzbG90ID0gdmJsYW5rLT5j b3VudCArIHZibGFua19jb3VudF9pbmM7Cj4gPj4+ICsJCXZibGFua3RpbWVzdGFtcChkZXYsIGNy dGMsIHRzbG90KSA9ICp0X3ZibGFuazsKPiA+Pj4gKwl9Cj4gPj4+ICsKPiA+Pj4gKwkvKgo+ID4+ PiArCSAqIHZibGFuayB0aW1lc3RhbXAgdXBkYXRlcyBhcmUgcHJvdGVjdGVkIG9uIHRoZSB3cml0 ZSBzaWRlIHdpdGgKPiA+Pj4gKwkgKiB2YmxhbmtfdGltZV9sb2NrLCBidXQgb24gdGhlIHJlYWQg c2lkZSBkb25lIGxvY2tsZXNzbHkgdXNpbmcgYQo+ID4+PiArCSAqIHNlcXVlbmNlLWxvY2sgb24g dGhlIHZibGFuayBjb3VudGVyLiBFbnN1cmUgY29ycmVjdCBvcmRlcmluZyB1c2luZwo+ID4+PiAr CSAqIG1lbW9yeSBiYXJycmllcnMuIFdlIG5lZWQgdGhlIGJhcnJpZXIgYm90aCBiZWZvcmUgYW5k IGFsc28gYWZ0ZXIgdGhlCj4gPj4+ICsJICogY291bnRlciB1cGRhdGUgdG8gc3luY2hyb25pemUg d2l0aCB0aGUgbmV4dCB0aW1lc3RhbXAgd3JpdGUuCj4gPj4+ICsJICogVGhlIHJlYWQtc2lkZSBi YXJyaWVycyBmb3IgdGhpcyBhcmUgaW4gZHJtX3ZibGFua19jb3VudF9hbmRfdGltZS4KPiA+Pj4g KwkgKi8KPiA+Pj4gKwlzbXBfd21iKCk7Cj4gPj4+ICsJdmJsYW5rLT5jb3VudCArPSB2Ymxhbmtf Y291bnRfaW5jOwo+ID4+PiArCXNtcF93bWIoKTsKPiA+Pgo+ID4+IFRoZSBjb21tZW50IGFuZCB0 aGUgY29kZSBhcmUgZWFjaCBzZWxmLWNvbnRyYWRpY3RvcnkuCj4gPj4KPiA+PiBJZiB2Ymxhbmst PmNvdW50IHdyaXRlcyBhcmUgYWx3YXlzIHByb3RlY3RlZCBieSB2YmxhbmtfdGltZV9sb2NrIChz b21ldGhpbmcgSQo+ID4+IGRpZCBub3QgdmVyaWZ5IGJ1dCB0aGF0IHRoZSBjb21tZW50IGFib3Zl IGFzc2VydHMpLCB0aGVuIHRoZSB0cmFpbGluZyB3cml0ZQo+ID4+IGJhcnJpZXIgaXMgbm90IHJl cXVpcmVkIChhbmQgdGhlIGFzc2VydGlvbiB0aGF0IGl0IGlzIGluIHRoZSBjb21tZW50IGlzIGlu Y29ycmVjdCkuCj4gPj4KPiA+PiBBIHNwaW4gdW5sb2NrIG9wZXJhdGlvbiBpcyBhbHdheXMgYSB3 cml0ZSBiYXJyaWVyLgo+ID4gCj4gPiBIbSB5ZWFoLiBPdG9oIHRvIG1lIHRoYXQncyBib3JkZXJp bmcgb24gImNvZGUgdG9vIGNsZXZlciBmb3IgbXkgb3duIGdvb2QiLgo+ID4gVGhhdCB0aGUgc3Bp bmxvY2sgaXMgaGVsZCBJIGNhbiBhc3N1cmUuIFRoYXQgbm8gb25lIGdvZXMgYXJvdW5kIGFuZCBk b2VzCj4gPiBtdWx0aXBsZSB2YmxhbmsgdXBkYXRlcyAoYmVjYXVzZSBzb21laG93IHRoYXQgY29k ZSByYWNlZCB3aXRoIHRoZSBodwo+ID4gaXRzZWxmKSBJIGNhbid0IGVhc2lseSBhc3N1cmUgd2l0 aCBhIHNpbXBsZSBhc3NlcnQgb3Igc29tZXRoaW5nIHNpbWlsYXIuCj4gPiBJdCdzIG5vdCB0aGUg Y2FzZSByaWdodCBub3csIGJ1dCB0aGF0IGNhbiBjaGFuZ2VzLgo+IAo+IFRoZSBhbGdvcml0aG0g d291bGQgYmUgYnJva2VuIGlmIG11bHRpcGxlIHVwZGF0ZXMgZm9yIHRoZSBzYW1lIHZibGFuawo+ IGNvdW50IHdlcmUgYWxsb3dlZDsgdGhhdCdzIHdoeSBpdCBjaGVja3MgdG8gc2VlIGlmIHRoZSB2 YmxhbmsgY291bnQgaGFzCj4gbm90IGFkdmFuY2VkIGJlZm9yZSBzdG9yaW5nIGEgbmV3IHRpbWVz dGFtcC4KPiAKPiBPdGhlcndpc2UsIHRoZSByZWFkIHNpZGUgd291bGQgbm90IGJlIGFibGUgdG8g ZGV0ZXJtaW5lIHRoYXQgdGhlCj4gdGltZXN0YW1wIGlzIHZhbGlkIGJ5IGRvdWJsZS1jaGVja2lu ZyB0aGF0IHRoZSB2YmxhbmsgY291bnQgaGFzIG5vdAo+IGNoYW5nZWQuCj4gCj4gQW5kIGJlc2lk ZXMsIGV2ZW4gaWYgdGhlIGNvZGUgbG9vcGVkIHdpdGhvdXQgZHJvcHBpbmcgdGhlIHNwaW5sb2Nr LAo+IHRoZSBjb3JyZWN0IHdyaXRlIG9yZGVyIHdvdWxkIHN0aWxsIGJlIG9ic2VydmVkIGJlY2F1 c2UgaXQgd291bGQgc3RpbGwKPiBiZSBleGVjdXRpbmcgb24gdGhlIHNhbWUgY3B1Lgo+IAo+IE15 IG9iamVjdGlvbiB0byB0aGUgd3JpdGUgbWVtb3J5IGJhcnJpZXIgaXMgbm90IGFib3V0IG9wdGlt aXphdGlvbjsKPiBpdCdzIGFib3V0IGNvcnJlY3QgY29kZS4KCldlbGwgZGlmZj0wIGlzIG5vdCBh bGxvd2VkLCBJIGd1ZXNzIEkgY291bGQgZW5mb3JjZSB0aGlzIHdpdGggc29tZQpXQVJOX09OLiBB bmQgSSBzdGlsbCB0aGluayBteSBwb2ludCBvZiBub24tbG9jYWwgY29ycmVjdG5lc3MgaXMgc29s aWQuCldpdGggdGhlIHNtcF93bWIoKSByZW1vdmVkIHRoZSBmb2xsb3dpbmcgc3RpbGwgd29ya3Mg Y29ycmVjdGx5OgoKc3Bpbl9sb2NrKHZibGFua190aW1lX2xvY2spOwpzdG9yZV92YmxhbmsoZGV2 LCBjcnRjLCAxLCB0czEpOwpzcGluX3VubG9jayh2YmxhbmtfdGltZV9sb2NrKTsKCnNwaW5fbG9j ayh2YmxhbmtfdGltZV9sb2NrKTsKc3RvcmVfdmJsYW5rKGRldiwgY3J0YywgMSwgdHMyKTsKc3Bp bl91bmxvY2sodmJsYW5rX3RpbWVfbG9jayk7CgpCdXQgd2l0aCB0aGUgc21wX3dtYigpOyByZW1v dmVkIHRoZSBmb2xsb3dpbmcgd291bGQgYmUgYnJva2VuOgoKc3Bpbl9sb2NrKHZibGFua190aW1l X2xvY2spOwpzdG9yZV92YmxhbmsoZGV2LCBjcnRjLCAxLCB0czEpOwpzdG9yZV92YmxhbmsoZGV2 LCBjcnRjLCAxLCB0czIpOwpzcGluX3VubG9jayh2YmxhbmtfdGltZV9sb2NrKTsKCmJlY2F1c2Ug dGhlIGNvbXBpbGVyL2NwdSBpcyBmcmVlIHRvIHJlb3JkZXIgdGhlIHN0b3JlIGZvciB2Ymxhbmst PmNvdW50Cl9haGVhZF8gb2YgdGhlIHN0b3JlIGZvciB0aGUgdGltZXN0YW1wLiBBbmQgdGhhdCB3 b3VsZCB0cmljayByZWFkZXJzIGludG8KYmVsaWV2aW5nIHRoYXQgdGhleSBoYXZlIGEgdmFsaWQg dGltZXN0YW1wIHdoZW4gdGhleSBwb3RlbnRpYWxseSByYWNlZC4KCk5vdyB5b3UncmUgY29ycmVj dCB0aGF0IHJpZ2h0IG5vdyB0aGVyZSdzIG5vIHN1Y2ggdGhpbmcgZ29pbmcgb24sIGFuZCBpdCdz CnVubGlrZWx5IHRvIGhhcHBlbiAoZ2l2ZW4gdGhlIG5hdHVyZSBvZiB2YmxhbmsgdXBkYXRlcyku IEJ1dCBteSBwb2ludCBpcwp0aGF0IGlmIHdlIG9wdGltaXplIHRoaXMgdGhlbiB0aGUgY29ycmVj dG5lc3MgY2FuJ3QgYmUgcHJvdmVuIGxvY2FsbHkKYW55bW9yZSBieSBqdXN0IGxvb2tpbmcgYXQg c3RvcmVfdmJsYW5rLCBidXQgaW5zdGVhZCB5b3UgbXVzdCBhdWRpdCBhbGwKdGhlIGNhbGxlcnMu IEFuZCBsZWFraW5nIGxvY2tpbmcvYmFycmllcnMgbGlrZSB0aGF0IGlzIHRvbyBmcmFnaWxlIGRl c2lnbgpmb3IgbXkgdGFzdGUuCgpCdXQgeW91IGluc2lzdCB0aGF0IG15IGFwcHJvYWNoIGlzIGJy b2tlbiBzb21laG93IGFuZCBkcm9wcGluZyB0aGUgc21wX3dtYgppcyBuZWVkZWQgZm9yIGNvcnJl Y3RuZXNzLiBJIGRvbid0IHNlZSBob3cgdGhhdCdzIHRoZSBjYXNlIGF0IGFsbC4KLURhbmllbAot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK