From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752580AbbDQIj0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Apr 2015 04:39:26 -0400
Received: from mail-wg0-f43.google.com ([74.125.82.43]:33127 "EHLO
	mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751086AbbDQIjU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Apr 2015 04:39:20 -0400
Date: Fri, 17 Apr 2015 10:39:16 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, jgross@suse.com,
        roland@purestorage.com, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [patch for 4.0] x86: silence warning in /dev/mem support
Message-ID: <20150417083915.GA12451@gmail.com>
References: <20150416080440.GA507@amd>
 <20150416100954.GA7847@gmail.com>
 <20150416101549.GB27776@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150416101549.GB27776@amd>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Pavel Machek <pavel@ucw.cz> wrote:

> On Thu 2015-04-16 12:09:54, Ingo Molnar wrote:
> > 
> > * Pavel Machek <pavel@ucw.cz> wrote:
> > 
> > > The compiler is right, the code is tricky, but it is also correct
> > > AFAICT.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > 
> > > diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
> > > index fdf617c..8a8dce8 100644
> > > --- a/arch/x86/mm/ioremap.c
> > > +++ b/arch/x86/mm/ioremap.c
> > > @@ -341,7 +341,7 @@ void *xlate_dev_mem_ptr(phys_addr_t phys)
> > >  
> > >  	addr = (void __force *)ioremap_cache(start, PAGE_SIZE);
> > >  	if (addr)
> > > -		addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK));
> > > +		addr = (void *)((unsigned long)addr | (unsigned long) (phys & ~PAGE_MASK));
> > 
> > What warning did it generate and which compiler version?
> 
> 
>   CC      arch/x86/mm/ioremap.o
>   arch/x86/mm/ioremap.c: In function ‘xlate_dev_mem_ptr’:
>   arch/x86/mm/ioremap.c:363:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>      addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK));
>                ^
>   LD      arch/x86/mm/built-in.o
> 		 
> pavel@amd:/data/l/linux$ gcc --version
> gcc (Debian 4.9.2-10) 4.9.2

So this code has not been changed for a year or so in theory, and I've 
never seen this warning with GCC 4.9.1. I'm wondering how it 
triggered. Could you send me your .config that triggers this?

Must have been introduced in:

  4707a341b4af /dev/mem: Use more consistent data types

Thanks,

	Ingo