From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48432)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1Yj4UP-0006h6-N3
	for qemu-devel@nongnu.org; Fri, 17 Apr 2015 07:31:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1Yj4UL-0002Ri-Ge
	for qemu-devel@nongnu.org; Fri, 17 Apr 2015 07:31:17 -0400
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:48250)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1Yj4UL-0002RC-73
	for qemu-devel@nongnu.org; Fri, 17 Apr 2015 07:31:13 -0400
Received: from /spool/local
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Fri, 17 Apr 2015 12:31:10 +0100
Received: from b06cxnps3075.portsmouth.uk.ibm.com
	(d06relay10.portsmouth.uk.ibm.com [9.149.109.195])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2F79717D8042
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2015 12:31:44 +0100 (BST)
Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com
	[9.149.37.247])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t3HBV7gG3932586
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2015 11:31:07 GMT
Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t3HBV6EX030090
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2015 05:31:06 -0600
Date: Fri, 17 Apr 2015 13:31:03 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20150417133103.1c3bbd80.cornelia.huck@de.ibm.com>
In-Reply-To: <1429246120-29439-8-git-send-email-jasowang@redhat.com>
References: <1429246120-29439-1-git-send-email-jasowang@redhat.com>
	<1429246120-29439-8-git-send-email-jasowang@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 07/16] virtio-ccw: using
 VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>, Alexander Graf <agraf@suse.de>, Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org, mst@redhat.com

On Fri, 17 Apr 2015 12:48:31 +0800
Jason Wang <jasowang@redhat.com> wrote:

> There's no need to use vector 0 for invalid virtqueue. So this patch

s/There's no need/It's a bad idea/

> changes to use VIRTIO_NO_VECTOR instead.

s/use/using/

> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> CC: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  hw/s390x/virtio-ccw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>