From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: Re: [PATCH V6 07/10] sched: add a macro to ref all CLONE_NEW* flags Date: Fri, 17 Apr 2015 11:42:50 -0400 Message-ID: <20150417154250.GA26233__29398.3798976571$1429285764$gmane$org@madcap2.tricolour.ca> References: <20150417081843.GE23123@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20150417081843.GE23123-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Peter Zijlstra Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pmoore-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-audit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, eparis-FjpueFixGhCM4zKIHC2jIg@public.gmane.org, sgrubb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, zohar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org List-Id: containers.vger.kernel.org On 15/04/17, Peter Zijlstra wrote: > On Fri, Apr 17, 2015 at 03:35:54AM -0400, Richard Guy Briggs wrote: > > Added the macro CLONE_NEW_MASK_ALL to refer to all CLONE_NEW* flags. > > A wee bit about why might be nice.. It makes the following patch much cleaner to read: [PATCH V6 08/10] fork: audit on creation of new namespace(s) https://lkml.org/lkml/2015/4/17/50 I was hoping it might also make a lot of other code cleaner, but most of the other places where multiple CLONE_NEW* flags are used, not all six are used together, but only 5 are used. Ok, so it is helpful in 1 of 3: It would actually be useful in check_unshare_flags(): https://github.com/torvalds/linux/blob/v3.17/kernel/fork.c#L1791 but not in copy_namespaces() or unshare_nsproxy_namespaces(): https://github.com/torvalds/linux/blob/v3.17/kernel/nsproxy.c#L130 https://github.com/torvalds/linux/blob/v3.17/kernel/nsproxy.c#L183 - RGB -- Richard Guy Briggs Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545