From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v2 2/2] drm/exynos: remove unused 'activated' field from exynos_drm_plane Date: Fri, 17 Apr 2015 16:00:17 -0300 Message-ID: <20150417190017.GB1997@joana> References: <1429127692-5772-1-git-send-email-tjakobi@math.uni-bielefeld.de> <1429127692-5772-3-git-send-email-tjakobi@math.uni-bielefeld.de> <5530A896.2020208@samsung.com> <456f092fcd8f60331518a44fe898b0eb@math.uni-bielefeld.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bhuna.collabora.co.uk ([93.93.135.160]:39406 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbbDQTAZ (ORCPT ); Fri, 17 Apr 2015 15:00:25 -0400 Content-Disposition: inline In-Reply-To: <456f092fcd8f60331518a44fe898b0eb@math.uni-bielefeld.de> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tobias Jakobi Cc: Joonyoung Shim , linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, inki.dae@samsung.com 2015-04-17 Tobias Jakobi : > Hello Joonyoung, > > On 2015-04-17 08:30, Joonyoung Shim wrote: > >Hi Tobias, > > > >On 04/16/2015 04:54 AM, Tobias Jakobi wrote: > >>No component of Exynos DRM uses this field. Perhaps it was > >>once meant to provide more fine-grained information in > >>addition to the status stored in the 'enabled' field. > >> > >>Reviewed-by: Gustavo Padovan > >>Signed-off-by: Tobias Jakobi > >>--- > >> drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >>diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h > >>b/drivers/gpu/drm/exynos/exynos_drm_drv.h > >>index 6a849cf..4c14a89 100644 > >>--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h > >>+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h > >>@@ -77,7 +77,6 @@ extern void exynos4412_qos(u8 tm, u8 ac); > >> * @color_key: color key on or off. > >> * @local_path: in case of lcd type, local path mode on or off. > >> * @transparency: transparency on or off. > >>- * @activated: activated or not. > >> * @enabled: enabled or not. > >> * @resume: to resume or not. > >> * > >>@@ -112,7 +111,6 @@ struct exynos_drm_plane { > >> bool color_key:1; > >> bool local_path:1; > >> bool transparency:1; > >>- bool activated:1; > >> bool enabled:1; > >> bool resume:1; > >> }; > >> > > > >The following fields also are unused in exynos drm driver, > >- default win, color_key, local_path, transparency > Yeah, looks like it. I just stumbled upon 'activated' because I was > wondering what the difference between 'enabled' and 'activated' was. > Grepping than revealed that nothing was using that field. I didn't check any > other fields. > > Also I just noticed that due to how git formats the patches, this one > doesn't apply to any of Inki's branches (due to the 'extern void > exynos4412_qos(u8 tm, u8 ac);' line). > > Should I respin this, and if yes, should I also drop the other fields > mentioned? Question is more directed to Gustavo, since he's cleaning > 'exynos_drm_plane' anyway. Let's remove them now, that doesn't affect my work. Gustavo