From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752675AbbDRJEb (ORCPT ); Sat, 18 Apr 2015 05:04:31 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:37900 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbbDRJE3 (ORCPT ); Sat, 18 Apr 2015 05:04:29 -0400 Date: Sat, 18 Apr 2015 10:04:20 +0100 From: Russell King - ARM Linux To: Greg Kroah-Hartman Cc: Jens Wiklander , valentin.manea@huawei.com, devicetree@vger.kernel.org, javier@javigon.com, emmanuel.michel@st.com, Herbert Xu , Arnd Bergmann , linux-kernel@vger.kernel.org, jean-michel.delorme@st.com, tpmdd-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 1/2] tee: generic TEE subsystem Message-ID: <20150418090420.GG12732@n2100.arm.linux.org.uk> References: <1429257057-7935-1-git-send-email-jens.wiklander@linaro.org> <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org> <20150418085712.GB29858@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150418085712.GB29858@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > > +struct tee_device { > > + char name[TEE_MAX_DEV_NAME_LEN]; > > + const struct tee_desc *desc; > > + struct device *dev; > > No, please embed the device in your structure, don't have a pointer to > it. Greg, "dev" here is not a locally allocated device, but the parent device. It's actually the same as struct tee_device.miscdev.parent, which could be used instead and this member deleted. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [RFC PATCH 1/2] tee: generic TEE subsystem Date: Sat, 18 Apr 2015 10:04:20 +0100 Message-ID: <20150418090420.GG12732@n2100.arm.linux.org.uk> References: <1429257057-7935-1-git-send-email-jens.wiklander@linaro.org> <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org> <20150418085712.GB29858@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150418085712.GB29858-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Kroah-Hartman Cc: Jens Wiklander , valentin.manea-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, javier-5MUHepqpBA1BDgjK7y7TUQ@public.gmane.org, emmanuel.michel-qxv4g6HH51o@public.gmane.org, Herbert Xu , Arnd Bergmann , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jean-michel.delorme-qxv4g6HH51o@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > > +struct tee_device { > > + char name[TEE_MAX_DEV_NAME_LEN]; > > + const struct tee_desc *desc; > > + struct device *dev; > > No, please embed the device in your structure, don't have a pointer to > it. Greg, "dev" here is not a locally allocated device, but the parent device. It's actually the same as struct tee_device.miscdev.parent, which could be used instead and this member deleted. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sat, 18 Apr 2015 10:04:20 +0100 Subject: [RFC PATCH 1/2] tee: generic TEE subsystem In-Reply-To: <20150418085712.GB29858@kroah.com> References: <1429257057-7935-1-git-send-email-jens.wiklander@linaro.org> <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org> <20150418085712.GB29858@kroah.com> Message-ID: <20150418090420.GG12732@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > > +struct tee_device { > > + char name[TEE_MAX_DEV_NAME_LEN]; > > + const struct tee_desc *desc; > > + struct device *dev; > > No, please embed the device in your structure, don't have a pointer to > it. Greg, "dev" here is not a locally allocated device, but the parent device. It's actually the same as struct tee_device.miscdev.parent, which could be used instead and this member deleted. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.