From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754600AbbDTIUN (ORCPT ); Mon, 20 Apr 2015 04:20:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41610 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754487AbbDTIUL (ORCPT ); Mon, 20 Apr 2015 04:20:11 -0400 Date: Mon, 20 Apr 2015 10:20:02 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , LKML , David Ahern Subject: Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui Message-ID: <20150420082002.GA9872@krava.redhat.com> References: <1429416255-12070-1-git-send-email-namhyung@kernel.org> <1429416255-12070-4-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429416255-12070-4-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote: > Since perf diff only support stdio output, TUI fields are only accessed > from perf report (or perf top). So add new struct hist_entry_tui and > move those fields into them. And include it as an union member. > SNIP > > - /* XXX These two should move to some tree widget lib */ > - u16 row_offset; > - u16 nr_rows; > - > bool init_have_children; > char level; > u8 filtered; > + union { > + struct hist_entry_diff diff; > + struct hist_entry_tui tui; > + }; could you please add the comment from changelog in here, so it's easy to figure this out in the future thanks, jirka