From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755431AbbDTOs1 (ORCPT ); Mon, 20 Apr 2015 10:48:27 -0400 Received: from smtprelay0254.hostedemail.com ([216.40.44.254]:37002 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755143AbbDTOsY (ORCPT ); Mon, 20 Apr 2015 10:48:24 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2895:2911:3138:3139:3140:3141:3142:3151:3353:3622:3865:3866:3867:3870:3871:3872:3873:3874:4321:4425:5007:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12296:12517:12519:12555:12679:12740:13069:13161:13229:13255:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: low39_2bc0f26d3422d X-Filterd-Recvd-Size: 2270 Date: Mon, 20 Apr 2015 10:48:19 -0400 From: Steven Rostedt To: Xunlei Pang Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Juri Lelli , Xunlei Pang Subject: Re: [PATCH v6 1/3] lib/plist: Provide plist_add_head() for nodes with the same prio Message-ID: <20150420104819.11eb8ca5@gandalf.local.home> In-Reply-To: <1429518168-7965-1-git-send-email-xlpang@126.com> References: <1429518168-7965-1-git-send-email-xlpang@126.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Apr 2015 16:22:46 +0800 Xunlei Pang wrote: > +/** > + * plist_add_tail - add @node to @head, after all existing same-prio nodes > + * > + * @node: The plist_node to be added to @head > + * @head: The plist_head that @node is being added to > + */ > +static inline > +void plist_add_tail(struct plist_node *node, struct plist_head *head) > +{ > + __plist_add(node, head, false); > +} > + > +#define plist_add plist_add_tail I already placed my review by, but this is more of a matter of taste. I don't think this should be a #define, but instead a static inline. The assembly will end up as the same, but the compiler warnings will be more helpful if it is a static inline, as we don't want "plist_add_tail()" being shown in warnings when the developer never typed in "_tail()". Thus it should be: static inline void plist_add(struct plist_node *node, struct plist_head *head) { plist_add_tail(node, head); } You can keep my Reviewed-by, but please make this update. -- Steve > + > extern void plist_del(struct plist_node *node, struct plist_head *head); > > extern void plist_requeue(struct plist_node *node, struct plist_head *head); > diff --git a/lib/plist.c b/lib/plist.c > index 3a30c53..c1ee2b0 100644 > --- a/lib/plist.c > +++ b/lib/plist.c