From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754909AbbDTML3 (ORCPT ); Mon, 20 Apr 2015 08:11:29 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:36009 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754548AbbDTML1 (ORCPT ); Mon, 20 Apr 2015 08:11:27 -0400 Date: Mon, 20 Apr 2015 21:10:20 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , LKML , David Ahern Subject: Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui Message-ID: <20150420121020.GB8483@danjae.kornet> References: <1429416255-12070-1-git-send-email-namhyung@kernel.org> <1429416255-12070-4-git-send-email-namhyung@kernel.org> <20150420082002.GA9872@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150420082002.GA9872@krava.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On Mon, Apr 20, 2015 at 10:20:02AM +0200, Jiri Olsa wrote: > On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote: > > Since perf diff only support stdio output, TUI fields are only accessed > > from perf report (or perf top). So add new struct hist_entry_tui and > > move those fields into them. And include it as an union member. > > > > SNIP > > > > > - /* XXX These two should move to some tree widget lib */ > > - u16 row_offset; > > - u16 nr_rows; > > - > > bool init_have_children; > > char level; > > u8 filtered; > > + union { > > + struct hist_entry_diff diff; > > + struct hist_entry_tui tui; > > + }; > > could you please add the comment from changelog in here, > so it's easy to figure this out in the future OK, will do. Thanks, Namhyung