From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkBTu-0003Wj-7p for qemu-devel@nongnu.org; Mon, 20 Apr 2015 09:11:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkBTp-0001VQ-Gz for qemu-devel@nongnu.org; Mon, 20 Apr 2015 09:11:22 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:34974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkBTp-0001V4-AW for qemu-devel@nongnu.org; Mon, 20 Apr 2015 09:11:17 -0400 Received: by wgyo15 with SMTP id o15so178615394wgy.2 for ; Mon, 20 Apr 2015 06:11:16 -0700 (PDT) Date: Mon, 20 Apr 2015 14:11:14 +0100 From: Stefan Hajnoczi Message-ID: <20150420131114.GB21246@stefanha-thinkpad.redhat.com> References: <1427391520-29497-1-git-send-email-pbonzini@redhat.com> <1427391520-29497-5-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WYTEVAkct0FjGQmd" Content-Disposition: inline In-Reply-To: <1427391520-29497-5-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org --WYTEVAkct0FjGQmd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 26, 2015 at 06:38:22PM +0100, Paolo Bonzini wrote: > diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c > index 46f7b41..be62dd6 100644 > --- a/hw/display/g364fb.c > +++ b/hw/display/g364fb.c > @@ -489,7 +489,7 @@ static void g364fb_init(DeviceState *dev, G364State *s) > memory_region_init_ram_ptr(&s->mem_vram, NULL, "vram", > s->vram_size, s->vram); > vmstate_register_ram(&s->mem_vram, dev); > - memory_region_set_coalescing(&s->mem_vram); > + memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA); This change isn't 100% clear to me. I guess that coalescing (performance optimization) doesn't make sense when logging is enabled? --WYTEVAkct0FjGQmd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVNPryAAoJEJykq7OBq3PIC0IH/2gCbeSNZyHhP8IqeA6XGBYW Tfcyk0qx2mtjKzaChNm4d+g5/Yr3V62si5/LVJjyv1kXtpfhhCrbv1GvJIWiVUYJ cWRYN6nx2XxhaJ0mqK768vdsrVymLVF3gv6x6ZNJCjg8dzACdpPF9q6DsevbzwWZ 3oS6kpwJof3FJ3HM3SBa9cVo/nL/H6DfudWIgmkO1IzkrAvUig0igGdMpMweMgJ8 7ZcGJ3fWgG1aH1ESF4mhY2ftm8mJ5VDJdvMNSv5tJbf52aa+sRdLZmeZBytpmROo 04z0ieqI3Bi8mTyeJnGcT5uJ2XnMsH0GYsr7ZrAUD+JWC+Cp8tZDyfuSnzZnwTY= =qDSg -----END PGP SIGNATURE----- --WYTEVAkct0FjGQmd--