All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Andi Kleen <andi@firstfloor.org>, Kan Liang <kan.liang@intel.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
	"eranian@google.com" <eranian@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/6] perf,core: allow invalid context events to be part of sw/hw groups
Date: Mon, 20 Apr 2015 18:57:22 +0200	[thread overview]
Message-ID: <20150420165722.GB2366@two.firstfloor.org> (raw)
In-Reply-To: <20150420101553.GE15875@leverpostej>

> If you don't care about sampling and only care about totals, then you
> can just open the events concurrently *without* grouping them, as I
> stated previously.

perf record doesn't really support that. We need some group reader
that runs regularly. The best choice for the leader is a CPU sample event,
which also has the advantage that it won't disturb idle states.

> > > From my PoV that violates group semantics, because now the events aren't
> > > always counting at the same time (which would be the reason I grouped
> > > them in the first place).
> > 
> > You never use the absolute value, just differences. The differences 
> > effectively count only when the group runs.
> 
> Except that the uncore PMU is counting during the periods the CPU PMU is
> disabled (e.g. when it is being programmed, read, or written). There's a
> race there that you cannot solve given the two are indepedent agents.

We get useful information, like

"memory bandwidth during the group run time".

You're right formulas between different PMUs are problematic though.
But in most cases time relation is good enough.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

      reply	other threads:[~2015-04-20 16:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15  7:56 [PATCH V2 1/6] perf,core: allow invalid context events to be part of sw/hw groups Kan Liang
2015-04-15  7:56 ` [PATCH V2 2/6] perf evsel: Set evsel->cpus to the evlist->cpus when not constrained Kan Liang
2015-04-15  7:56 ` [PATCH V2 3/6] perf,tools: get real cpu id for print_aggr Kan Liang
2015-04-15  7:56 ` [PATCH V2 4/6] perf,tools: check and re-organize evsel cpu maps Kan Liang
2015-04-16 16:33   ` Mark Rutland
2015-04-15  7:56 ` [PATCH V2 5/6] perf,tools: open/mmap event uses event's cpu map Kan Liang
2015-04-15  7:56 ` [PATCH V2 6/6] perf/x86/intel/uncore: do not implicitly set uncore event cpu Kan Liang
2015-04-16 16:36   ` Mark Rutland
2015-04-15 16:15 ` [PATCH V2 1/6] perf,core: allow invalid context events to be part of sw/hw groups Peter Zijlstra
2015-04-15 16:21   ` Andi Kleen
2015-04-15 16:55     ` Peter Zijlstra
2015-04-15 17:28 ` Peter Zijlstra
2015-04-16 14:53   ` Liang, Kan
2015-04-16 16:31 ` Mark Rutland
2015-04-16 16:43   ` Mark Rutland
2015-04-16 17:16   ` Mark Rutland
2015-04-16 21:23   ` Andi Kleen
2015-04-17  9:47     ` Mark Rutland
2015-04-18  0:47       ` Andi Kleen
2015-04-20 10:15         ` Mark Rutland
2015-04-20 16:57           ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150420165722.GB2366@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=eranian@google.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.