From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753431AbbDTREX (ORCPT ); Mon, 20 Apr 2015 13:04:23 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:33808 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757AbbDTREU (ORCPT ); Mon, 20 Apr 2015 13:04:20 -0400 Date: Mon, 20 Apr 2015 10:04:15 -0700 From: Dmitry Torokhov To: Benson Leung Cc: Dudley Du , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] input: cyapa: fix update suspend scanrate set to max 1000 issue Message-ID: <20150420170415.GA21614@dtor-ws> References: <1429508594-24255-1-git-send-email-dudl@cypress.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2015 at 10:00:42AM -0700, Benson Leung wrote: > Hi Dudley. > > Just a minor commit message nit. Thanks! > > On Sun, Apr 19, 2015 at 10:43 PM, Dudley Du wrote: > > Fix update suspend scareate always set to max 1000 issue, the root cause is > s/scareate/scanrate > > the missed using max_t as min_t. > > TEST=test on Chromebook. > > > > Signed-off-by: Dudley Du > > Reviewed-by: Benson Leung Applied, thank you. > > > --- > > drivers/input/mouse/cyapa.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c > > index 58f4f6f..efe1484 100644 > > --- a/drivers/input/mouse/cyapa.c > > +++ b/drivers/input/mouse/cyapa.c > > @@ -723,7 +723,7 @@ static ssize_t cyapa_update_suspend_scanrate(struct device *dev, > > } else if (sysfs_streq(buf, OFF_MODE_NAME)) { > > cyapa->suspend_power_mode = PWR_MODE_OFF; > > } else if (!kstrtou16(buf, 10, &sleep_time)) { > > - cyapa->suspend_sleep_time = max_t(u16, sleep_time, 1000); > > + cyapa->suspend_sleep_time = min_t(u16, sleep_time, 1000); > > cyapa->suspend_power_mode = > > cyapa_sleep_time_to_pwr_cmd(cyapa->suspend_sleep_time); > > } else { > > @@ -840,7 +840,7 @@ static ssize_t cyapa_update_rt_suspend_scanrate(struct device *dev, > > if (error) > > return error; > > > > - cyapa->runtime_suspend_sleep_time = max_t(u16, time, 1000); > > + cyapa->runtime_suspend_sleep_time = min_t(u16, time, 1000); > > cyapa->runtime_suspend_power_mode = > > cyapa_sleep_time_to_pwr_cmd(cyapa->runtime_suspend_sleep_time); > > > > -- > > 1.9.1 > > > > > > -- > Benson Leung > Software Engineer, Chrome OS > Google Inc. > bleung@google.com -- Dmitry