From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbbDTUOT (ORCPT ); Mon, 20 Apr 2015 16:14:19 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38673 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbbDTUOO (ORCPT ); Mon, 20 Apr 2015 16:14:14 -0400 Date: Mon, 20 Apr 2015 21:14:01 +0100 From: Mark Brown To: Kevin Cernekee Cc: Liam Girdwood , dgreid@chromium.org, Andrew Bresticker , Olof Johansson , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Message-ID: <20150420201401.GP6023@sirena.org.uk> References: <1429134141-17924-1-git-send-email-cernekee@chromium.org> <1429134141-17924-2-git-send-email-cernekee@chromium.org> <20150418113632.GE26185@sirena.org.uk> <20150418171137.GY26185@sirena.org.uk> <20150420122129.GC14892@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IoGhzFUztgUGyjlj" Content-Disposition: inline In-Reply-To: X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IoGhzFUztgUGyjlj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 20, 2015 at 08:12:36AM -0700, Kevin Cernekee wrote: > On Mon, Apr 20, 2015 at 5:21 AM, Mark Brown wrote: > >> The same check shows up in numerous other drivers, including the one > >> for the audio controller on my board. > > Sounds like either that (undisclosed) driver has a problem or you're > > using it inappropriately. > I don't think this driver has been posted on the list yet, but the > checks show up in these two functions: > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/sound/soc/img/concerto-audio.c#108 > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/sound/soc/img/concerto-audio.c#147 > Any suggestions on what to change? That driver has not been posted previously (and looks like it could use some rework for mainline). If it doesn't care if it set the clock and is just trying for information it should be handling -ENOTSUPP, that's why the core returns that value. --IoGhzFUztgUGyjlj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVNV4IAAoJECTWi3JdVIfQXvoH/1ixR5v9Aqshr0pA5YIU3WKW ee7JO1fgi79H7UprhSioxEfB/nyNhU6crR8Rm0lFsigk+OAJ7J+1rW1rc7TmWunq 376Z2Ek+oBNT20oqPoiQtnehXjlcexeW3YygvcIsyYPmM3xwEjx79A9gfawQCkiT QGd8fGrkq08+4jWxIY/t+Uq4u+0pTj25scGwVaQZ0jXqtDCNCVxsSEcNt5NoUmFc jcl1Om2i1mVPhpfZrlwv7yUIWQ6c86wlONSxhbfbbasK7ENd6E8i52JEbyHi2zzf a+b3XyB76z5IR2EeTGq4hRgsnCsnK8OKyojuAiMWHtQdmlKfeWX4IgZ+1oo/IjM= =yQ1T -----END PGP SIGNATURE----- --IoGhzFUztgUGyjlj-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers Date: Mon, 20 Apr 2015 21:14:01 +0100 Message-ID: <20150420201401.GP6023@sirena.org.uk> References: <1429134141-17924-1-git-send-email-cernekee@chromium.org> <1429134141-17924-2-git-send-email-cernekee@chromium.org> <20150418113632.GE26185@sirena.org.uk> <20150418171137.GY26185@sirena.org.uk> <20150420122129.GC14892@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IoGhzFUztgUGyjlj" Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kevin Cernekee Cc: Liam Girdwood , dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Andrew Bresticker , Olof Johansson , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org --IoGhzFUztgUGyjlj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 20, 2015 at 08:12:36AM -0700, Kevin Cernekee wrote: > On Mon, Apr 20, 2015 at 5:21 AM, Mark Brown wrote: > >> The same check shows up in numerous other drivers, including the one > >> for the audio controller on my board. > > Sounds like either that (undisclosed) driver has a problem or you're > > using it inappropriately. > I don't think this driver has been posted on the list yet, but the > checks show up in these two functions: > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/sound/soc/img/concerto-audio.c#108 > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/sound/soc/img/concerto-audio.c#147 > Any suggestions on what to change? That driver has not been posted previously (and looks like it could use some rework for mainline). If it doesn't care if it set the clock and is just trying for information it should be handling -ENOTSUPP, that's why the core returns that value. --IoGhzFUztgUGyjlj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVNV4IAAoJECTWi3JdVIfQXvoH/1ixR5v9Aqshr0pA5YIU3WKW ee7JO1fgi79H7UprhSioxEfB/nyNhU6crR8Rm0lFsigk+OAJ7J+1rW1rc7TmWunq 376Z2Ek+oBNT20oqPoiQtnehXjlcexeW3YygvcIsyYPmM3xwEjx79A9gfawQCkiT QGd8fGrkq08+4jWxIY/t+Uq4u+0pTj25scGwVaQZ0jXqtDCNCVxsSEcNt5NoUmFc jcl1Om2i1mVPhpfZrlwv7yUIWQ6c86wlONSxhbfbbasK7ENd6E8i52JEbyHi2zzf a+b3XyB76z5IR2EeTGq4hRgsnCsnK8OKyojuAiMWHtQdmlKfeWX4IgZ+1oo/IjM= =yQ1T -----END PGP SIGNATURE----- --IoGhzFUztgUGyjlj-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html