Re: [RFC 1/9] ASoC: hda: Add helper to read/write to dsp mmio space

From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: liam.r.girdwood@linux.intel.com, tiwai@suse.de,
	alsa-devel@alsa-project.org,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
	patches.audio@intel.com
Subject: Re: [RFC 1/9] ASoC: hda: Add helper to read/write to dsp mmio space
Date: Wed, 22 Apr 2015 09:20:14 +0530	[thread overview]
Message-ID: <20150422035014.GD2738@intel.com> (raw)
In-Reply-To: <20150420214638.GX14892@sirena.org.uk>


[-- Attachment #1.1: Type: text/plain, Size: 630 bytes --]

On Mon, Apr 20, 2015 at 10:46:38PM +0100, Mark Brown wrote:
> On Fri, Apr 17, 2015 at 06:45:59PM +0530, Vinod Koul wrote:
> 
> > +u8 ssth_readb_traced(struct ssth_lib *dsp, u32 offset)
> > +{
> > +	u8 val;
> > +
> > +	val = readb((dsp)->mmio_base + offset);
> > +	dev_dbg(dsp->dev, "readb offset=%#x val=%#x\n", offset, val);
> > +
> > +	return val;
> > +}
> 
> Much of this looks like a MMIO regmap, there's the memcpy() bits too
> which aren't but otherwise...
Yes they are. memcpy bits are to copy the IPC mailbox payload data to aDSP
RAM which can range from few bytes to couple of KBs

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]