From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755987AbbDVFoc (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Apr 2015 01:44:32 -0400
Received: from mga11.intel.com ([192.55.52.93]:20034 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753149AbbDVFoa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Apr 2015 01:44:30 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,621,1422950400"; 
   d="scan'208";a="698965372"
Date: Wed, 22 Apr 2015 08:44:22 +0300
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: peterhuewe@gmx.de, tpmdd-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Marcel Selhorst <tpmdd@selhorst.net>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tejun Heo <tj@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jianyu Zhan <nasa4836@gmail.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andrzej Hajda <a.hajda@samsung.com>, NeilBrown <neilb@suse.de>,
        Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH v2] tpm: enable PPI for TPM 2.0
Message-ID: <20150422054422.GB6764@intel.com>
References: <1429641062-14421-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <20150421185825.GA8366@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150421185825.GA8366@roeck-us.net>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 21, 2015 at 11:58:33AM -0700, Guenter Roeck wrote:
> On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote:
> > Enabled PPI interface to the character device sysfs directory accessible
> > both for 1.x and 2.0 devices.
> > 
> > The ppi group is moved from the platform device directory to the
> > character device directory. In order to retain backwards compatibility
> > with the 1.x devices, a symlink is created to the platform device
> > directory.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Reviewed-by: Jason Gunthorpe <jason.gunthorpe@obsidianresearch.com>
> > ---
> >  drivers/char/tpm/tpm-chip.c | 21 +++++++++++++--------
> >  drivers/char/tpm/tpm.h      | 17 ++++++-----------
> >  drivers/char/tpm/tpm_ppi.c  | 34 +++++++++++-----------------------
> >  fs/kernfs/dir.c             |  1 +
> >  fs/sysfs/group.c            | 42 ++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/sysfs.h       |  8 ++++++++
> 
> Shouldn't the sysfs changes be a separate patch ?

Yes, I think it would make sense. I'll refine this as a patch set.
Thanks.

> Guenter

/Jarkko