From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkqhV-0003aX-67 for qemu-devel@nongnu.org; Wed, 22 Apr 2015 05:12:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkqhS-0002IS-Gk for qemu-devel@nongnu.org; Wed, 22 Apr 2015 05:12:09 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:33441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkqhS-0002IG-96 for qemu-devel@nongnu.org; Wed, 22 Apr 2015 05:12:06 -0400 Received: by wiax7 with SMTP id x7so125328562wia.0 for ; Wed, 22 Apr 2015 02:12:05 -0700 (PDT) Date: Wed, 22 Apr 2015 10:12:02 +0100 From: Stefan Hajnoczi Message-ID: <20150422091202.GC6581@stefanha-thinkpad.redhat.com> References: <1427391520-29497-1-git-send-email-pbonzini@redhat.com> <1427391520-29497-5-git-send-email-pbonzini@redhat.com> <20150420131114.GB21246@stefanha-thinkpad.redhat.com> <5535052C.6080701@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z4+8/lEcDcG5Ke9S" Content-Disposition: inline In-Reply-To: <5535052C.6080701@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org --z4+8/lEcDcG5Ke9S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 20, 2015 at 03:54:52PM +0200, Paolo Bonzini wrote: >=20 >=20 > On 20/04/2015 15:11, Stefan Hajnoczi wrote: > >> - memory_region_set_coalescing(&s->mem_vram); + > >> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA); > >=20 > > This change isn't 100% clear to me. I guess that coalescing=20 > > (performance optimization) doesn't make sense when logging is > > enabled? >=20 > No, it's just that coalescing is for MMIO, not RAM. Setting > coalescing was a no-op. I'll make this a separate patch. Thanks! --z4+8/lEcDcG5Ke9S Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVN2XiAAoJEJykq7OBq3PIJzMH/27bV/ddXaYRHAbPAXWOuhKe Np/ArkR4Fry2alj5xRozRNpdTKim3/j0EzQ1yhed7gzkvDJHyohLosGpjznx/4jb 4PMySqndBoGyiCcos+x/YD5mOItNhCJmHwBj+dRaME9NJQindidZxR+UN9mNv/mj tftdp9yNbQ+/5itKTZS1yy6ajvvLarFkEevvPWyYCzSYKIZfr/RuzZ5CJm3krz7+ 2bcQbONjDzRoT24XV4hCEEvglpEMdwsIDAzRqQQngDKBZLXCjMssskWWojytggtE P/mM3YIFTEVlW+wjrTnkMSq+TtHSmKM357kDKv13HSGAIaL+tUPT8XBEzLMZaxE= =fpsX -----END PGP SIGNATURE----- --z4+8/lEcDcG5Ke9S--