Re: [PATCH 08/10] perf hists browser: Split popup menu actions - part 2

From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 08/10] perf hists browser: Split popup menu actions - part 2
Date: Wed, 22 Apr 2015 22:03:25 +0900	[thread overview]
Message-ID: <20150422130325.GA1622@danjae.kornet> (raw)
In-Reply-To: <20150422105409.GA27697@krava.redhat.com>

Hi Jiri,

On Wed, Apr 22, 2015 at 12:54:09PM +0200, Jiri Olsa wrote:
> On Wed, Apr 22, 2015 at 04:18:19PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> >  	script_browse(script_opt);
> > @@ -1505,17 +1585,74 @@ do_run_script(struct hist_browser *browser __maybe_unused,
> >  }
> >  
> >  static int
> > -do_switch_data(struct hist_browser *browser __maybe_unused, int key)
> > +add_script_opt(struct hist_browser *browser __maybe_unused,
> > +	       struct popup_action *act, char **optstr,
> > +	       struct thread *thread, struct symbol *sym)
> > +{
> > +	if (thread) {
> > +		if (asprintf(optstr, "Run scripts for samples of thread [%s]",
> > +			     thread__comm_str(thread)) < 0)
> > +			return 0;
> > +	} else if (sym) {
> 
>          ..............  && sym->namelen ;-)

Ouch!  sorry for missing this again.

Arnaldo, any chance you can fix this if you're gonna merge it?

> 
> but I think you're right, let's see if there's (sym && !sym->namelen) case,
> and fix it at the proper place.. not here

Agreed.

Thanks,
Namhyung