From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757087AbbDVODj (ORCPT ); Wed, 22 Apr 2015 10:03:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38499 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756129AbbDVODh (ORCPT ); Wed, 22 Apr 2015 10:03:37 -0400 Date: Wed, 22 Apr 2015 16:02:45 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Adrian Hunter , Ingo Molnar , Peter Zijlstra , LKML , David Ahern Subject: Re: [PATCH 08/10] perf hists browser: Split popup menu actions - part 2 Message-ID: <20150422140245.GB29174@krava.redhat.com> References: <1429687101-4360-1-git-send-email-namhyung@kernel.org> <1429687101-4360-9-git-send-email-namhyung@kernel.org> <20150422105409.GA27697@krava.redhat.com> <20150422130325.GA1622@danjae.kornet> <20150422132550.GA2316@kernel.org> <20150422134120.GA29174@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2015 at 10:53:45PM +0900, Namhyung Kim wrote: > On Wed, Apr 22, 2015 at 10:41 PM, Jiri Olsa wrote: > > On Wed, Apr 22, 2015 at 10:32:21PM +0900, Namhyung Kim wrote: > >> On Wed, Apr 22, 2015 at 10:25 PM, Arnaldo Carvalho de Melo > >> wrote: > >> > Em Wed, Apr 22, 2015 at 10:03:25PM +0900, Namhyung Kim escreveu: > >> >> Hi Jiri, > >> >> > >> >> On Wed, Apr 22, 2015 at 12:54:09PM +0200, Jiri Olsa wrote: > >> >> > On Wed, Apr 22, 2015 at 04:18:19PM +0900, Namhyung Kim wrote: > >> >> > > + if (asprintf(optstr, "Run scripts for samples of thread [%s]", > >> >> > > + thread__comm_str(thread)) < 0) > >> >> > > + return 0; > >> >> > > + } else if (sym) { > >> > > >> >> > .............. && sym->namelen ;-) > >> > > >> >> Ouch! sorry for missing this again. > >> > > >> >> Arnaldo, any chance you can fix this if you're gonna merge it? > >> > > >> > I can do that, but that slows down my rate of merging, so, if you could > >> > do like Adrian Hunter did, and fix this up, stick a V2 tag to it, then > >> > send it as a reply to the patch being fixed, that would help, so that > >> > when I get to it, and sort by thread, I will see the fix and will use > >> > it instead. > >> > >> OK. Will send v2 soon! > > > > hum, I just told Arnaldo that I'm ok with not having the sym->namelen check.. > > > > let's leave it as it is now and if we see blank line > > then we go and fix it on the proper place > > Argh, I misunderstood your point, I thought you wanted to leave the > sym->namelen check here and removing it in another patch with some > more investigation. Yes, English is hard for me - I feel it more and > more these days ;-) no worries, I believe mine is worse ;-) > > So it's all OK in the current form, right? yep jirka