From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753781AbbDVSKb (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Apr 2015 14:10:31 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:48227 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751560AbbDVSK2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Apr 2015 14:10:28 -0400
Date: Wed, 22 Apr 2015 20:10:24 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Simon Wunderlich <sw@simonwunderlich.de>, NeilBrown <neilb@suse.de>,
        linux-kernel@vger.kernel.org, Jianyu Zhan <nasa4836@gmail.com>,
        Andrzej Hajda <a.hajda@samsung.com>, tpmdd-devel@lists.sourceforge.net,
        Al Viro <viro@zeniv.linux.org.uk>, Tejun Heo <tj@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>,
        "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [tpmdd-devel] [PATCH v2] tpm: enable PPI for TPM 2.0
Message-ID: <20150422181024.GA4340@kroah.com>
References: <1429641062-14421-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <20150421193338.GA31179@obsidianresearch.com>
 <20150422055755.GC6764@intel.com>
 <20150422163855.GA12013@intel.com>
 <20150422172243.GE19500@obsidianresearch.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150422172243.GE19500@obsidianresearch.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 22, 2015 at 11:22:43AM -0600, Jason Gunthorpe wrote:
> On Wed, Apr 22, 2015 at 07:38:55PM +0300, Jarkko Sakkinen wrote:
> > > > > +EXPORT_SYMBOL_GPL(kernfs_remove_by_name_ns);
> > > > 
> > > > ??
> > > > I don't see this being called
> > > 
> > > My bad, it is clutter in the patch file. I'll remove it.
> > 
> > In fact this is needed because the driver uses kernfs_remove_by_name,
> > which is an inline function that uses kernfs_remove_by_name_ns
> > internally.
> 
> Hum, that probably needs a sysfs_ analog - the paired removal
> function for sysfs_link_group_to_kobj ?

Be very careful using that sysfs function, you shouldn't be doing that
within a driver subsystem unless you know what you are doing :)

greg k-h