All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: pang.xunlei@zte.com.cn
Cc: Juri Lelli <juri.lelli@gmail.com>,
	linux-kernel@vger.kernel.org,
	Xunlei Pang <pang.xunlei@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v6 2/3] sched/rt: Fix wrong SMP scheduler behavior for equal prio cases
Date: Thu, 23 Apr 2015 09:10:57 -0400	[thread overview]
Message-ID: <20150423091057.05bcc309@gandalf.local.home> (raw)
In-Reply-To: <OFE3B71874.C9D81693-ON48257E30.0024F69F-48257E30.0025E2D3@zte.com.cn>

On Thu, 23 Apr 2015 14:53:27 +0800
pang.xunlei@zte.com.cn wrote:
 
> > Why not use Peter's idea of instead of checking PREEMPT_ACTIVE, just
> > check if the task is on the runqueue or not. If it scheduled out, it
> > would take itself off the runqueue, if it was preempted by anything, it
> > would still be on the run queue, and according to FIFO, it should still
> > maintain CPU ownership over other tasks of the same prio.
> > 
> 
> But for yield() or RR scheduling when running out of time slice, 
> I think this would be still inappropriate, am I missing something? 

Good point, I'll have to look into this a bit more.

-- Steve

  parent reply	other threads:[~2015-04-23 13:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20  8:22 [PATCH v6 1/3] lib/plist: Provide plist_add_head() for nodes with the same prio Xunlei Pang
2015-04-20  8:22 ` [PATCH v6 2/3] sched/rt: Fix wrong SMP scheduler behavior for equal prio cases Xunlei Pang
2015-04-20 14:52   ` Steven Rostedt
2015-04-20 17:20     ` Peter Zijlstra
2015-04-20 17:48       ` Steven Rostedt
2015-04-20 23:45         ` Peter Zijlstra
2015-04-21 13:10           ` Steven Rostedt
     [not found]         ` <OFB1503F16.1E65406F-ON48257E2E.002B562D-48257E30.0008BFEB@zte.com.cn>
2015-04-23  3:01           ` Steven Rostedt
     [not found]             ` <OFE3B71874.C9D81693-ON48257E30.0024F69F-48257E30.0025E2D3@zte.com.cn>
2015-04-23 13:10               ` Steven Rostedt [this message]
2015-04-24 18:32               ` Peter Zijlstra
     [not found]                 ` <OF0B05B4FE.F40C0BE3-ON48257E32.004EF485-48257E32.00513DB3@zte.com.cn>
2015-04-25 18:23                   ` Peter Zijlstra
     [not found]                     ` <OFD410EB1E.5A02675A-ON48257E33.00309252-48257E33.003641FF@zte.com.cn>
2015-04-26 15:58                       ` Steven Rostedt
2015-04-28 10:19                         ` Peter Zijlstra
2015-04-28 12:48                           ` Mike Galbraith
2015-04-20  8:22 ` [PATCH v6 3/3] sched/rt: Check to push the task when changing its affinity Xunlei Pang
2015-04-20 16:06   ` Steven Rostedt
2015-04-20 14:42 ` [PATCH v6 1/3] lib/plist: Provide plist_add_head() for nodes with the same prio Steven Rostedt
2015-04-20 14:48 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150423091057.05bcc309@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=juri.lelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pang.xunlei@linaro.org \
    --cc=pang.xunlei@zte.com.cn \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.