Re: [LTP] [PATCH] device-drivers/zram: new zram test

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> +zram_compress_alg()
> +{
> +	tst_resm TINFO "test that we can set compression algorithm"
> +	local algs=$(cat /sys/block/zram0/comp_algorithm)
> +	tst_resm TINFO "supported algs: $algs"
> +	local i=0
> +	for alg in $zram_algs; do
> +		local sys_path="/sys/block/zram${i}/comp_algorithm"
> +		echo "$alg" >  $sys_path || \
> +			tst_brkm TFAIL "can't set 'lzo' to $sys_path"
                                                   ^
					Shouldn't this be $alg ?
> +		i=$(($i + 1))
> +		tst_resm TINFO "$sys_path = 'lzo' ($i/$dev_num)"
                                             ^
				      Here as well.
> +	done
> +
> +	tst_resm TPASS "test succeeded"
> +}
> +

Otherwise it looks good, acked.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list