From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965029AbbDWLrm (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Apr 2015 07:47:42 -0400
Received: from mail-wi0-f170.google.com ([209.85.212.170]:34637 "EHLO
	mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757565AbbDWLrJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Apr 2015 07:47:09 -0400
Date: Thu, 23 Apr 2015 13:47:06 +0200
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Marcelo Tosatti <mtosatt@redhat.com>,
        John Stultz <john.stultz@linaro.org>,
        Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 18/39] tick: sched: Force tick interrupt and get rid of
 softirq magic
Message-ID: <20150423114704.GA22800@lerouge>
References: <20150414203303.702062272@linutronix.de>
 <20150414203502.023464878@linutronix.de>
 <20150422142213.GA16832@lerouge>
 <alpine.DEB.2.11.1504221627190.13914@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.11.1504221627190.13914@nanos>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 22, 2015 at 04:32:11PM +0200, Thomas Gleixner wrote:
> On Wed, 22 Apr 2015, Frederic Weisbecker wrote:
> > But the reprogramming happens only under "if ((long)delta_jiffies >= 1)".
> > Probably this condition should go away as well.
> 
> Errm.
> 
> 	if (!ts->tick_stopped && delta_jiffies <= 1)
> 	     goto out;
> 
> So if the tick is NOT stopped and delta_jiffies <= 1 we let it tick
> and do nothing.
> 
>         if (delta_jiffies >= 1)
> 	     Do the magic nohz stuff
> 	else
> 	     tick_nohz_restart()
> 
> We want the distinction here because if the tick IS stopped and the
> next event is due we need to kick it into gear again. So the condition
> needs to stay. It probably should be if (delta > 1), but that's a
> different story.

Yes but what if the tick is stopped already and delta_jiffies < 1? Say the
tick was last programmed to fire in 5 seconds. An irq fires and enqueues
a timer to fire now. If it's soon enough that delta_jiffies < 1, it seems
we are missing the clock reprogramming and even the softirq from that irq exit.

Because we have:

      if (!ts->tick_stopped && delta_jiffies <= 1)
          goto out;

      if ((long)delta_jiffies >= 1) {
          //do clock reprogramming or restart
          ...
      }

-     raise_softirq(TIMER_SOFTIRQ);

 out:
    ...

>  
> > In the end, the possible side effect, at least on low-res, is that timers
> > which are already expired will be handled on the next tick instead of now.
> > But probably it doesn't matter much to have a one-tick delay.
> 
> We really don't care. That stuff has no guarantees aside of the
> guarantee that it does not expire early :)

Good :)

> 
> Thanks,
> 
> 	tglx
>