All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] include:configs:ls1021atwr: Enable USB IP support
Date: Thu, 23 Apr 2015 13:56:12 +0200	[thread overview]
Message-ID: <201504231356.12216.marex@denx.de> (raw)
In-Reply-To: <BL2PR03MB16158790A9FE3338128796DE0ED0@BL2PR03MB161.namprd03.prod.outlook.com>

On Thursday, April 23, 2015 at 08:51:14 AM, Ramneek Mehresh wrote:
> > -----Original Message-----
> > From: Marek Vasut [mailto:marex at denx.de]
> > Sent: Wednesday, April 22, 2015 5:18 PM
> > To: Mehresh Ramneek-B31383
> > Cc: u-boot at lists.denx.de
> > Subject: Re: [PATCH 3/4] include:configs:ls1021atwr: Enable USB IP
> > support
> > 
> > On Wednesday, April 22, 2015 at 08:49:42 AM, Ramneek Mehresh wrote:
> > > Enable USB IP support for both EHCI and XHCI for ls1021atwr platform
> > > 
> > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> > > ---
> > > 
> > >  include/configs/ls1021atwr.h | 29 +++++++++++++++++++++++++++++
> > > 
> > > include/linux/usb/xhci-fsl.h |  5 +++++
> > > 
> > >  2 files changed, 34 insertions(+)
> > > 
> > > diff --git a/include/configs/ls1021atwr.h
> > > b/include/configs/ls1021atwr.h index a13876b..0f59b3c 100644
> > > --- a/include/configs/ls1021atwr.h
> > > +++ b/include/configs/ls1021atwr.h
> > > @@ -28,6 +28,35 @@
> > > 
> > >  #define CONFIG_SYS_INIT_RAM_SIZE	OCRAM_SIZE
> > >  
> > >  /*
> > > 
> > > + * USB
> > > + */
> > > +/* EHCI Support - disbaled by default */
> > 
> > 'disabled'
> > 
> > > +/*#define CONFIG_HAS_FSL_DR_USB*/
> > 
> > Why is this disabled ?
> 
> EHCI is disabled because this controller is not exposed via any connector
> on the board. However, the silicon still has this controller, and anyone
> can use this controller by taking signals out on their board.
> XHCI can be used on the board via micro-A usb host connector

Oki, please document it a bit better. The thing you just wrote would be exactly
the nice piece of documentation/comment which should be in the code.

Thanks!

Best regards,
Marek Vasut

  reply	other threads:[~2015-04-23 11:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22  6:49 [U-Boot] [PATCH 1/4] drivers:usb:dwc3: Add DWC3 controller driver support Ramneek Mehresh
2015-04-22  6:49 ` [U-Boot] [PATCH 2/4] drivers:usb:fsl: Add XHCI " Ramneek Mehresh
2015-04-22 11:47   ` Marek Vasut
2015-04-23  6:54     ` Ramneek Mehresh
2015-04-22  6:49 ` [U-Boot] [PATCH 3/4] include:configs:ls1021atwr: Enable USB IP support Ramneek Mehresh
2015-04-22 11:48   ` Marek Vasut
2015-04-23  6:51     ` Ramneek Mehresh
2015-04-23 11:56       ` Marek Vasut [this message]
2015-04-23 11:59         ` Ramneek Mehresh
2015-04-22  6:49 ` [U-Boot] [PATCH 4/4] include:configs:ls1021aqds: " Ramneek Mehresh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504231356.12216.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.