[U-Boot] [PATCH 5/5] mx6cuboxi: Load the correct 'fdt_file' variable

[Tom Rini <trini@konsulko.com>]

On Thu, Apr 23, 2015 at 08:13:05AM +0200, Stefano Babic wrote:
> Hi Fabio,
> 
> On 23/04/2015 05:57, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Instead of hardcoding the 'fdt_file' variable, let's introduce a new
> > function - build_dts_name(), that can build the dtb filename on the fly.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >  board/solidrun/mx6cuboxi/mx6cuboxi.c | 24 ++++++++++++++++++++++++
> >  include/configs/mx6cuboxi.h          |  3 +--
> >  2 files changed, 25 insertions(+), 2 deletions(-)
> > 
> > diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> > index 83410b2..1c24a55 100644
> > --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> > +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> > @@ -212,6 +212,30 @@ int checkboard(void)
> >  	return 0;
> >  }
> >  
> > +static const char *build_dts_name(void)
> > +{
> > +	char *dt_prefix = "unknown";
> > +	char *dt_suffix = "unknown";
> > +
> > +	if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D))
> > +		dt_prefix = "imx6q";
> > +	else if (is_cpu_type(MXC_CPU_MX6SOLO) || is_cpu_type(MXC_CPU_MX6DL))
> > +		dt_prefix = "imx6dl";
> > +
> > +	if (is_hummingboard())
> > +		dt_suffix = "-hummingboard.dtb";
> > +	else
> > +		dt_suffix = "-cubox-i.dtb";
> > +
> > +	return strcat(dt_prefix, dt_suffix);
> > +}
> > +
> 
> I admit I do not like a lot to have C code setting / fixing the
> environment. This has the drawback that when a user try to set the
> environment from the console as he wants, he cannot because the code has
> reverted back and it is not easy to track. I would like to propose
> another solution.

Yes.  Please see how this is done for the various TI boards where we
export into the env enough information to make these kind of decisions
in the shell.  This is even more applicable here as we don't have the
dynamic "pick a DT" for Falcon Mode that the Solid Run tree has where
this originated in.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150423/bb5a16f8/attachment.sig>