From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752796AbbDXKI1 (ORCPT ); Fri, 24 Apr 2015 06:08:27 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:39478 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbbDXKIY convert rfc822-to-8bit (ORCPT ); Fri, 24 Apr 2015 06:08:24 -0400 From: Juergen Borleis Organization: Pengutronix e.K. To: linux-arm-kernel@lists.infradead.org Subject: Re: [rtc-linux] [PATCH 1/5] RTC/i.MX/DryIce: add some background info about the states the machine can be in Date: Fri, 24 Apr 2015 12:10:43 +0200 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: Alexandre Belloni , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Robert Schwebel , kernel@pengutronix.de References: <1429002716-19821-1-git-send-email-jbe@pengutronix.de> <1429002716-19821-2-git-send-email-jbe@pengutronix.de> <20150421220942.GB8539@piout.net> In-Reply-To: <20150421220942.GB8539@piout.net> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201504241210.43768.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:6f8:1178:4:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Wednesday 22 April 2015 00:09:42 Alexandre Belloni wrote: > [...] > > --- > > drivers/rtc/rtc-imxdi.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c > > index c666eab..8750477 100644 > > --- a/drivers/rtc/rtc-imxdi.c > > +++ b/drivers/rtc/rtc-imxdi.c > > @@ -129,6 +129,49 @@ struct imxdi_dev { > > struct work_struct work; > > }; > > > > +/* Some background: > > + * > > + * The DryIce unit is a complex security/tamper monitor device. To be able do > > + * its job in a useful manner it runs a bigger statemachine to bring it into > > + * security/tamper failure state and once again to bring it out of this state. > > + * > > + * This unit can be in one of three states: > > + * > > + * - "NON-VALID STATE" > > + * always after the battery power was removed > > + * - "FAILURE STATE" > > + * if one of the enabled security events have happend > > has happened ^ > > > + * - "VALID STATE" > > + * if the unit works as expected > > + * > > + * Everything stops when the unit enters the failure state including the > > RTC + * counter (to be able to detect the time the security event > > happend). > > happened ^ > [...] Thanks for the feedback. Fixed in the next version. Regards, Juergen -- Pengutronix e.K.                              | Juergen Borleis             | Industrial Linux Solutions      | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de. [2001:6f8:1178:4:290:27ff:fe1d:cc33]) by gmr-mx.google.com with ESMTPS id k2si111733wif.0.2015.04.24.03.08.23 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 24 Apr 2015 03:08:23 -0700 (PDT) From: Juergen Borleis To: linux-arm-kernel@lists.infradead.org Subject: Re: [rtc-linux] [PATCH 1/5] RTC/i.MX/DryIce: add some background info about the states the machine can be in Date: Fri, 24 Apr 2015 12:10:43 +0200 Cc: Alexandre Belloni , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Robert Schwebel , kernel@pengutronix.de References: <1429002716-19821-1-git-send-email-jbe@pengutronix.de> <1429002716-19821-2-git-send-email-jbe@pengutronix.de> <20150421220942.GB8539@piout.net> In-Reply-To: <20150421220942.GB8539@piout.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Message-Id: <201504241210.43768.jbe@pengutronix.de> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi Alexandre, On Wednesday 22 April 2015 00:09:42 Alexandre Belloni wrote: > [...] > > --- > > drivers/rtc/rtc-imxdi.c | 43 +++++++++++++++++++++++++++++++++++++++++= ++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c > > index c666eab..8750477 100644 > > --- a/drivers/rtc/rtc-imxdi.c > > +++ b/drivers/rtc/rtc-imxdi.c > > @@ -129,6 +129,49 @@ struct imxdi_dev { > > struct work_struct work; > > }; > > > > +/* Some background: > > + * > > + * The DryIce unit is a complex security/tamper monitor device. To be = able do > > + * its job in a useful manner it runs a bigger statemachine to bring i= t into > > + * security/tamper failure state and once again to bring it out of thi= s state. > > + *=20 > > + * This unit can be in one of three states: > > + * > > + * - "NON-VALID STATE" > > + * always after the battery power was removed > > + * - "FAILURE STATE" > > + * if one of the enabled security events have happend > > has happened ^ > > > + * - "VALID STATE" > > + * if the unit works as expected > > + * > > + * Everything stops when the unit enters the failure state including t= he > > RTC + * counter (to be able to detect the time the security event > > happend). > > happened ^ > [...] Thanks for the feedback. Fixed in the next version. Regards, Juergen =2D-=20 Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0| Juergen Borleis =A0 =A0 =A0 =A0 =A0 =A0 | Industrial Linux Solutions =A0 =A0 =A0| http://www.pengutroni= x.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbe@pengutronix.de (Juergen Borleis) Date: Fri, 24 Apr 2015 12:10:43 +0200 Subject: [rtc-linux] [PATCH 1/5] RTC/i.MX/DryIce: add some background info about the states the machine can be in In-Reply-To: <20150421220942.GB8539@piout.net> References: <1429002716-19821-1-git-send-email-jbe@pengutronix.de> <1429002716-19821-2-git-send-email-jbe@pengutronix.de> <20150421220942.GB8539@piout.net> Message-ID: <201504241210.43768.jbe@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Alexandre, On Wednesday 22 April 2015 00:09:42 Alexandre Belloni wrote: > [...] > > --- > > drivers/rtc/rtc-imxdi.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c > > index c666eab..8750477 100644 > > --- a/drivers/rtc/rtc-imxdi.c > > +++ b/drivers/rtc/rtc-imxdi.c > > @@ -129,6 +129,49 @@ struct imxdi_dev { > > struct work_struct work; > > }; > > > > +/* Some background: > > + * > > + * The DryIce unit is a complex security/tamper monitor device. To be able do > > + * its job in a useful manner it runs a bigger statemachine to bring it into > > + * security/tamper failure state and once again to bring it out of this state. > > + * > > + * This unit can be in one of three states: > > + * > > + * - "NON-VALID STATE" > > + * always after the battery power was removed > > + * - "FAILURE STATE" > > + * if one of the enabled security events have happend > > has happened ^ > > > + * - "VALID STATE" > > + * if the unit works as expected > > + * > > + * Everything stops when the unit enters the failure state including the > > RTC + * counter (to be able to detect the time the security event > > happend). > > happened ^ > [...] Thanks for the feedback. Fixed in the next version. Regards, Juergen -- Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Juergen Borleis ? ? ? ? ? ? | Industrial Linux Solutions ? ? ?| http://www.pengutronix.de/ |