From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from cantor2.suse.de ([195.135.220.15]:51603 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966397AbbDXQIS (ORCPT ); Fri, 24 Apr 2015 12:08:18 -0400 Date: Fri, 24 Apr 2015 18:08:11 +0200 From: Jan Kara To: Hans Verkuil Cc: Marek Szyprowski , Jan Kara , linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , linux-mm@kvack.org, dri-devel@lists.freedesktop.org, David Airlie , Pawel Osciak Subject: Re: [PATCH 0/9 v2] Helper to abstract vma handling in media layer Message-ID: <20150424160811.GB18074@quack.suse.cz> References: <1426593399-6549-1-git-send-email-jack@suse.cz> <20150402150258.GA31277@quack.suse.cz> <551D5F7C.4080400@xs4all.nl> <553A2229.5040509@samsung.com> <553A23F9.1080504@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <553A23F9.1080504@xs4all.nl> Sender: linux-media-owner@vger.kernel.org List-ID: On Fri 24-04-15 13:07:37, Hans Verkuil wrote: > Hi Marek, > > On 04/24/2015 12:59 PM, Marek Szyprowski wrote: > > Dear All, > > > > On 2015-04-02 17:25, Hans Verkuil wrote: > >> On 04/02/2015 05:02 PM, Jan Kara wrote: > >>> Hello, > >>> > >>> On Tue 17-03-15 12:56:30, Jan Kara wrote: > >>>> After a long pause I'm sending second version of my patch series to abstract > >>>> vma handling from the various media drivers. After this patch set drivers have > >>>> to know much less details about vmas, their types, and locking. My motivation > >>>> for the series is that I want to change get_user_pages() locking and I want to > >>>> handle subtle locking details in as few places as possible. > >>>> > >>>> The core of the series is the new helper get_vaddr_pfns() which is given a > >>>> virtual address and it fills in PFNs into provided array. If PFNs correspond to > >>>> normal pages it also grabs references to these pages. The difference from > >>>> get_user_pages() is that this function can also deal with pfnmap, mixed, and io > >>>> mappings which is what the media drivers need. > >>>> > >>>> I have tested the patches with vivid driver so at least vb2 code got some > >>>> exposure. Conversion of other drivers was just compile-tested so I'd like to > >>>> ask respective maintainers if they could have a look. Also I'd like to ask mm > >>>> folks to check patch 2/9 implementing the helper. Thanks! > >>> Ping? Any reactions? > >> For patch 1/9: > >> > >> Acked-by: Hans Verkuil > >> > >> For the other patches I do not feel qualified to give Acks. I've Cc-ed Pawel and > >> Marek who have a better understanding of the mm internals than I do. Hopefully > >> they can review the code. > >> > >> It definitely looks like a good idea, and if nobody else will comment on the vb2 > >> patches in the next 2 weeks, then I'll try to review it myself (for whatever that's > >> worth). > > > > I'm really sorry that I didn't manage to find time to review this > > patchset. I really > > like the idea of moving pfn lookup from videobuf2/driver to some common > > code in mm > > and it is really great that someone managed to provide nice generic code > > for it. > > > > I've applied the whole patchset onto v4.0 and tested it on Odroid U3 > > (with some > > additional patches). VideoBuf2-dc works still fine with USERPTR gathered > > from other's > > device mmaped buffer. You can add my: > > > > Acked-by: Marek Szyprowski > > Tested-by: Marek Szyprowski > > Thanks! Thank you both for having a look at the patches! > > for the patches 1-8. Patch 9/9 doesn't apply anymore, so I've skipped > > it. Patch 2 > > needs a small fixup - you need to add '#include ', > > because otherwise > > it doesn't compile. There have been also a minor conflict to be resolved > > in patch 7. > > I've just added patch 1/9 to my pull request for 4.2. But for patch 2/9 I need > Acks from the mm maintainers. I think it makes sense if patches 2-8 all go > in together via the linux-media tree. Jan, can you reach out to the right > devs to get Acks? Sure, I'll ping some mm guys explicitely. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by kanga.kvack.org (Postfix) with ESMTP id 62FBA6B0038 for ; Fri, 24 Apr 2015 12:08:19 -0400 (EDT) Received: by wgyo15 with SMTP id o15so55649228wgy.2 for ; Fri, 24 Apr 2015 09:08:19 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id p8si20120971wjx.82.2015.04.24.09.08.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Apr 2015 09:08:17 -0700 (PDT) Date: Fri, 24 Apr 2015 18:08:11 +0200 From: Jan Kara Subject: Re: [PATCH 0/9 v2] Helper to abstract vma handling in media layer Message-ID: <20150424160811.GB18074@quack.suse.cz> References: <1426593399-6549-1-git-send-email-jack@suse.cz> <20150402150258.GA31277@quack.suse.cz> <551D5F7C.4080400@xs4all.nl> <553A2229.5040509@samsung.com> <553A23F9.1080504@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <553A23F9.1080504@xs4all.nl> Sender: owner-linux-mm@kvack.org List-ID: To: Hans Verkuil Cc: Marek Szyprowski , Jan Kara , linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , linux-mm@kvack.org, dri-devel@lists.freedesktop.org, David Airlie , Pawel Osciak On Fri 24-04-15 13:07:37, Hans Verkuil wrote: > Hi Marek, > > On 04/24/2015 12:59 PM, Marek Szyprowski wrote: > > Dear All, > > > > On 2015-04-02 17:25, Hans Verkuil wrote: > >> On 04/02/2015 05:02 PM, Jan Kara wrote: > >>> Hello, > >>> > >>> On Tue 17-03-15 12:56:30, Jan Kara wrote: > >>>> After a long pause I'm sending second version of my patch series to abstract > >>>> vma handling from the various media drivers. After this patch set drivers have > >>>> to know much less details about vmas, their types, and locking. My motivation > >>>> for the series is that I want to change get_user_pages() locking and I want to > >>>> handle subtle locking details in as few places as possible. > >>>> > >>>> The core of the series is the new helper get_vaddr_pfns() which is given a > >>>> virtual address and it fills in PFNs into provided array. If PFNs correspond to > >>>> normal pages it also grabs references to these pages. The difference from > >>>> get_user_pages() is that this function can also deal with pfnmap, mixed, and io > >>>> mappings which is what the media drivers need. > >>>> > >>>> I have tested the patches with vivid driver so at least vb2 code got some > >>>> exposure. Conversion of other drivers was just compile-tested so I'd like to > >>>> ask respective maintainers if they could have a look. Also I'd like to ask mm > >>>> folks to check patch 2/9 implementing the helper. Thanks! > >>> Ping? Any reactions? > >> For patch 1/9: > >> > >> Acked-by: Hans Verkuil > >> > >> For the other patches I do not feel qualified to give Acks. I've Cc-ed Pawel and > >> Marek who have a better understanding of the mm internals than I do. Hopefully > >> they can review the code. > >> > >> It definitely looks like a good idea, and if nobody else will comment on the vb2 > >> patches in the next 2 weeks, then I'll try to review it myself (for whatever that's > >> worth). > > > > I'm really sorry that I didn't manage to find time to review this > > patchset. I really > > like the idea of moving pfn lookup from videobuf2/driver to some common > > code in mm > > and it is really great that someone managed to provide nice generic code > > for it. > > > > I've applied the whole patchset onto v4.0 and tested it on Odroid U3 > > (with some > > additional patches). VideoBuf2-dc works still fine with USERPTR gathered > > from other's > > device mmaped buffer. You can add my: > > > > Acked-by: Marek Szyprowski > > Tested-by: Marek Szyprowski > > Thanks! Thank you both for having a look at the patches! > > for the patches 1-8. Patch 9/9 doesn't apply anymore, so I've skipped > > it. Patch 2 > > needs a small fixup - you need to add '#include ', > > because otherwise > > it doesn't compile. There have been also a minor conflict to be resolved > > in patch 7. > > I've just added patch 1/9 to my pull request for 4.2. But for patch 2/9 I need > Acks from the mm maintainers. I think it makes sense if patches 2-8 all go > in together via the linux-media tree. Jan, can you reach out to the right > devs to get Acks? Sure, I'll ping some mm guys explicitely. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 0/9 v2] Helper to abstract vma handling in media layer Date: Fri, 24 Apr 2015 18:08:11 +0200 Message-ID: <20150424160811.GB18074@quack.suse.cz> References: <1426593399-6549-1-git-send-email-jack@suse.cz> <20150402150258.GA31277@quack.suse.cz> <551D5F7C.4080400@xs4all.nl> <553A2229.5040509@samsung.com> <553A23F9.1080504@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 6019772103 for ; Fri, 24 Apr 2015 09:08:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <553A23F9.1080504@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: Jan Kara , Pawel Osciak , Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Hans Verkuil , Marek Szyprowski , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpIDI0LTA0LTE1IDEzOjA3OjM3LCBIYW5zIFZlcmt1aWwgd3JvdGU6Cj4gSGkgTWFyZWss Cj4gCj4gT24gMDQvMjQvMjAxNSAxMjo1OSBQTSwgTWFyZWsgU3p5cHJvd3NraSB3cm90ZToKPiA+ IERlYXIgQWxsLAo+ID4gCj4gPiBPbiAyMDE1LTA0LTAyIDE3OjI1LCBIYW5zIFZlcmt1aWwgd3Jv dGU6Cj4gPj4gT24gMDQvMDIvMjAxNSAwNTowMiBQTSwgSmFuIEthcmEgd3JvdGU6Cj4gPj4+ICAg IEhlbGxvLAo+ID4+Pgo+ID4+PiBPbiBUdWUgMTctMDMtMTUgMTI6NTY6MzAsIEphbiBLYXJhIHdy b3RlOgo+ID4+Pj4gICAgQWZ0ZXIgYSBsb25nIHBhdXNlIEknbSBzZW5kaW5nIHNlY29uZCB2ZXJz aW9uIG9mIG15IHBhdGNoIHNlcmllcyB0byBhYnN0cmFjdAo+ID4+Pj4gdm1hIGhhbmRsaW5nIGZy b20gdGhlIHZhcmlvdXMgbWVkaWEgZHJpdmVycy4gQWZ0ZXIgdGhpcyBwYXRjaCBzZXQgZHJpdmVy cyBoYXZlCj4gPj4+PiB0byBrbm93IG11Y2ggbGVzcyBkZXRhaWxzIGFib3V0IHZtYXMsIHRoZWly IHR5cGVzLCBhbmQgbG9ja2luZy4gTXkgbW90aXZhdGlvbgo+ID4+Pj4gZm9yIHRoZSBzZXJpZXMg aXMgdGhhdCBJIHdhbnQgdG8gY2hhbmdlIGdldF91c2VyX3BhZ2VzKCkgbG9ja2luZyBhbmQgSSB3 YW50IHRvCj4gPj4+PiBoYW5kbGUgc3VidGxlIGxvY2tpbmcgZGV0YWlscyBpbiBhcyBmZXcgcGxh Y2VzIGFzIHBvc3NpYmxlLgo+ID4+Pj4KPiA+Pj4+IFRoZSBjb3JlIG9mIHRoZSBzZXJpZXMgaXMg dGhlIG5ldyBoZWxwZXIgZ2V0X3ZhZGRyX3BmbnMoKSB3aGljaCBpcyBnaXZlbiBhCj4gPj4+PiB2 aXJ0dWFsIGFkZHJlc3MgYW5kIGl0IGZpbGxzIGluIFBGTnMgaW50byBwcm92aWRlZCBhcnJheS4g SWYgUEZOcyBjb3JyZXNwb25kIHRvCj4gPj4+PiBub3JtYWwgcGFnZXMgaXQgYWxzbyBncmFicyBy ZWZlcmVuY2VzIHRvIHRoZXNlIHBhZ2VzLiBUaGUgZGlmZmVyZW5jZSBmcm9tCj4gPj4+PiBnZXRf dXNlcl9wYWdlcygpIGlzIHRoYXQgdGhpcyBmdW5jdGlvbiBjYW4gYWxzbyBkZWFsIHdpdGggcGZu bWFwLCBtaXhlZCwgYW5kIGlvCj4gPj4+PiBtYXBwaW5ncyB3aGljaCBpcyB3aGF0IHRoZSBtZWRp YSBkcml2ZXJzIG5lZWQuCj4gPj4+Pgo+ID4+Pj4gSSBoYXZlIHRlc3RlZCB0aGUgcGF0Y2hlcyB3 aXRoIHZpdmlkIGRyaXZlciBzbyBhdCBsZWFzdCB2YjIgY29kZSBnb3Qgc29tZQo+ID4+Pj4gZXhw b3N1cmUuIENvbnZlcnNpb24gb2Ygb3RoZXIgZHJpdmVycyB3YXMganVzdCBjb21waWxlLXRlc3Rl ZCBzbyBJJ2QgbGlrZSB0bwo+ID4+Pj4gYXNrIHJlc3BlY3RpdmUgbWFpbnRhaW5lcnMgaWYgdGhl eSBjb3VsZCBoYXZlIGEgbG9vay4gIEFsc28gSSdkIGxpa2UgdG8gYXNrIG1tCj4gPj4+PiBmb2xr cyB0byBjaGVjayBwYXRjaCAyLzkgaW1wbGVtZW50aW5nIHRoZSBoZWxwZXIuIFRoYW5rcyEKPiA+ Pj4gICAgUGluZz8gQW55IHJlYWN0aW9ucz8KPiA+PiBGb3IgcGF0Y2ggMS85Ogo+ID4+Cj4gPj4g QWNrZWQtYnk6IEhhbnMgVmVya3VpbCA8aGFucy52ZXJrdWlsQGNpc2NvLmNvbT4KPiA+Pgo+ID4+ IEZvciB0aGUgb3RoZXIgcGF0Y2hlcyBJIGRvIG5vdCBmZWVsIHF1YWxpZmllZCB0byBnaXZlIEFj a3MuIEkndmUgQ2MtZWQgUGF3ZWwgYW5kCj4gPj4gTWFyZWsgd2hvIGhhdmUgYSBiZXR0ZXIgdW5k ZXJzdGFuZGluZyBvZiB0aGUgbW0gaW50ZXJuYWxzIHRoYW4gSSBkby4gSG9wZWZ1bGx5Cj4gPj4g dGhleSBjYW4gcmV2aWV3IHRoZSBjb2RlLgo+ID4+Cj4gPj4gSXQgZGVmaW5pdGVseSBsb29rcyBs aWtlIGEgZ29vZCBpZGVhLCBhbmQgaWYgbm9ib2R5IGVsc2Ugd2lsbCBjb21tZW50IG9uIHRoZSB2 YjIKPiA+PiBwYXRjaGVzIGluIHRoZSBuZXh0IDIgd2Vla3MsIHRoZW4gSSdsbCB0cnkgdG8gcmV2 aWV3IGl0IG15c2VsZiAoZm9yIHdoYXRldmVyIHRoYXQncwo+ID4+IHdvcnRoKS4KPiA+IAo+ID4g SSdtIHJlYWxseSBzb3JyeSB0aGF0IEkgZGlkbid0IG1hbmFnZSB0byBmaW5kIHRpbWUgdG8gcmV2 aWV3IHRoaXMgCj4gPiBwYXRjaHNldC4gSSByZWFsbHkKPiA+IGxpa2UgdGhlIGlkZWEgb2YgbW92 aW5nIHBmbiBsb29rdXAgZnJvbSB2aWRlb2J1ZjIvZHJpdmVyIHRvIHNvbWUgY29tbW9uIAo+ID4g Y29kZSBpbiBtbQo+ID4gYW5kIGl0IGlzIHJlYWxseSBncmVhdCB0aGF0IHNvbWVvbmUgbWFuYWdl ZCB0byBwcm92aWRlIG5pY2UgZ2VuZXJpYyBjb2RlIAo+ID4gZm9yIGl0Lgo+ID4gCj4gPiBJJ3Zl IGFwcGxpZWQgdGhlIHdob2xlIHBhdGNoc2V0IG9udG8gdjQuMCBhbmQgdGVzdGVkIGl0IG9uIE9k cm9pZCBVMyAKPiA+ICh3aXRoIHNvbWUKPiA+IGFkZGl0aW9uYWwgcGF0Y2hlcykuIFZpZGVvQnVm Mi1kYyB3b3JrcyBzdGlsbCBmaW5lIHdpdGggVVNFUlBUUiBnYXRoZXJlZCAKPiA+IGZyb20gb3Ro ZXIncwo+ID4gZGV2aWNlIG1tYXBlZCBidWZmZXIuIFlvdSBjYW4gYWRkIG15Ogo+ID4gCj4gPiBB Y2tlZC1ieTogTWFyZWsgU3p5cHJvd3NraSA8bS5zenlwcm93c2tpQHNhbXN1bmcuY29tPgo+ID4g VGVzdGVkLWJ5OiBNYXJlayBTenlwcm93c2tpIDxtLnN6eXByb3dza2lAc2Ftc3VuZy5jb20+Cj4g Cj4gVGhhbmtzIQogIFRoYW5rIHlvdSBib3RoIGZvciBoYXZpbmcgYSBsb29rIGF0IHRoZSBwYXRj aGVzIQoKPiA+IGZvciB0aGUgcGF0Y2hlcyAxLTguIFBhdGNoIDkvOSBkb2Vzbid0IGFwcGx5IGFu eW1vcmUsIHNvIEkndmUgc2tpcHBlZCAKPiA+IGl0LiBQYXRjaCAyCj4gPiBuZWVkcyBhIHNtYWxs IGZpeHVwIC0geW91IG5lZWQgdG8gYWRkICcjaW5jbHVkZSA8bGludXgvdm1hbGxvYy5oPicsIAo+ ID4gYmVjYXVzZSBvdGhlcndpc2UKPiA+IGl0IGRvZXNuJ3QgY29tcGlsZS4gVGhlcmUgaGF2ZSBi ZWVuIGFsc28gYSBtaW5vciBjb25mbGljdCB0byBiZSByZXNvbHZlZCAKPiA+IGluIHBhdGNoIDcu Cj4gCj4gSSd2ZSBqdXN0IGFkZGVkIHBhdGNoIDEvOSB0byBteSBwdWxsIHJlcXVlc3QgZm9yIDQu Mi4gQnV0IGZvciBwYXRjaCAyLzkgSSBuZWVkCj4gQWNrcyBmcm9tIHRoZSBtbSBtYWludGFpbmVy cy4gSSB0aGluayBpdCBtYWtlcyBzZW5zZSBpZiBwYXRjaGVzIDItOCBhbGwgZ28KPiBpbiB0b2dl dGhlciB2aWEgdGhlIGxpbnV4LW1lZGlhIHRyZWUuIEphbiwgY2FuIHlvdSByZWFjaCBvdXQgdG8g dGhlIHJpZ2h0Cj4gZGV2cyB0byBnZXQgQWNrcz8KICBTdXJlLCBJJ2xsIHBpbmcgc29tZSBtbSBn dXlzIGV4cGxpY2l0ZWx5LgoKCQkJCQkJCQlIb256YQotLSAKSmFuIEthcmEgPGphY2tAc3VzZS5j ej4KU1VTRSBMYWJzLCBDUgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=