From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
Lokesh Vutla <lokeshvutla@ti.com>, Felipe Balbi <balbi@ti.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 3/3] watchdog: omap: simplify assignment of bootstatus
Date: Sun, 26 Apr 2015 21:14:13 +0200 [thread overview]
Message-ID: <20150426191413.GA19431@pengutronix.de> (raw)
In-Reply-To: <553D0410.4010802@roeck-us.net>
Hello Guenter,
On Sun, Apr 26, 2015 at 08:28:16AM -0700, Guenter Roeck wrote:
> if you don't mind, can you sesend the entire series ?
yeah, that's my plan. I already fixed it for Felipe's comments and
intend to resend tomorrow.
> I don't think patch 1 applies after 1a, and it might make sense
> to add some more explanation to patch 2. FWIW, I would say that using
> to_omap_wdt_dev() instead of watchdog_get_drvdata() simplifies the code,
> or simply that the functions are no longer needed in the driver (ugliness
> may be seen as personal opinion).
>
> When you do so, please feel free to add
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net> to all four patches.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2015-04-26 19:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 9:48 [PATCH 0/3] watchdog: omap: several cleanups Uwe Kleine-König
2015-04-24 9:48 ` [PATCH 1/3] watchdog: omap: use watchdog_init_timeout Uwe Kleine-König
2015-04-24 14:42 ` Felipe Balbi
2015-04-24 14:42 ` Felipe Balbi
2015-04-24 19:02 ` Uwe Kleine-König
2015-04-24 19:02 ` Uwe Kleine-König
2015-04-24 20:20 ` [PATCH 1a/3] watchdog: omap: clearify device tree documentation Uwe Kleine-König
2015-04-24 20:20 ` Uwe Kleine-König
2015-04-25 2:10 ` Felipe Balbi
2015-04-25 2:10 ` Felipe Balbi
2015-04-26 15:29 ` Guenter Roeck
2015-04-26 15:29 ` Guenter Roeck
2015-04-26 19:12 ` Uwe Kleine-König
2015-04-26 19:12 ` Uwe Kleine-König
2015-04-26 19:46 ` Guenter Roeck
2015-04-26 19:46 ` Guenter Roeck
2015-04-24 9:48 ` [PATCH 2/3] watchdog: omap: put struct watchdog_device into driver data Uwe Kleine-König
2015-04-24 14:44 ` Felipe Balbi
2015-04-24 14:44 ` Felipe Balbi
2015-04-24 19:10 ` Uwe Kleine-König
2015-04-24 19:10 ` Uwe Kleine-König
2015-04-24 9:48 ` [PATCH 3/3] watchdog: omap: simplify assignment of bootstatus Uwe Kleine-König
2015-04-24 14:45 ` Felipe Balbi
2015-04-24 14:45 ` Felipe Balbi
2015-04-24 19:03 ` Uwe Kleine-König
2015-04-26 15:28 ` Guenter Roeck
2015-04-26 19:14 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150426191413.GA19431@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=balbi@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lokeshvutla@ti.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.