From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965614AbbD1MOn (ORCPT ); Tue, 28 Apr 2015 08:14:43 -0400 Received: from verein.lst.de ([213.95.11.211]:40691 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965417AbbD1MOk (ORCPT ); Tue, 28 Apr 2015 08:14:40 -0400 Date: Tue, 28 Apr 2015 14:14:38 +0200 From: Christoph Hellwig To: Ming Lin Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , Kent Overstreet , Dongsu Park , linux-bcache@vger.kernel.org Subject: Re: [PATCH 04/10] bcache: clean up hacks around bio_split_pool Message-ID: <20150428121438.GB10479@lst.de> References: <1430203717-13307-1-git-send-email-mlin@kernel.org> <1430203717-13307-5-git-send-email-mlin@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430203717-13307-5-git-send-email-mlin@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2015 at 11:48:31PM -0700, Ming Lin wrote: > From: Kent Overstreet > > There has been workarounds only in bcache, for splitting pool as well > as submitting bios. Since generic_make_request() is able to handle > arbitrarily sized bios, it's now possible to delete those hacks. The Subject and description look confusing to me. >>From me reading of the code I'd word it as: Subject: bcache: remove driver private bio splitting code The bcache driver has always accepted arbitrarily large bios and split them internally. Now that every driver must accept arbitrarily large bios this code isn't nessecary anymore. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 04/10] bcache: clean up hacks around bio_split_pool Date: Tue, 28 Apr 2015 14:14:38 +0200 Message-ID: <20150428121438.GB10479@lst.de> References: <1430203717-13307-1-git-send-email-mlin@kernel.org> <1430203717-13307-5-git-send-email-mlin@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:40691 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965417AbbD1MOk (ORCPT ); Tue, 28 Apr 2015 08:14:40 -0400 Content-Disposition: inline In-Reply-To: <1430203717-13307-5-git-send-email-mlin@kernel.org> Sender: linux-bcache-owner@vger.kernel.org List-Id: linux-bcache@vger.kernel.org To: Ming Lin Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , Kent Overstreet , Dongsu Park , linux-bcache@vger.kernel.org On Mon, Apr 27, 2015 at 11:48:31PM -0700, Ming Lin wrote: > From: Kent Overstreet > > There has been workarounds only in bcache, for splitting pool as well > as submitting bios. Since generic_make_request() is able to handle > arbitrarily sized bios, it's now possible to delete those hacks. The Subject and description look confusing to me. >From me reading of the code I'd word it as: Subject: bcache: remove driver private bio splitting code The bcache driver has always accepted arbitrarily large bios and split them internally. Now that every driver must accept arbitrarily large bios this code isn't nessecary anymore.