All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Cui Bixuan <cuibixuan@huawei.com>
Cc: zhuyanpeng@huawei.com, ltp-list@lists.sourceforge.net,
	zhanyongming@huawei.com
Subject: Re: [LTP] [PATCH v5 1/2] syscalls/utimensat01: Use test.sh library for test case
Date: Tue, 28 Apr 2015 14:39:35 +0200	[thread overview]
Message-ID: <20150428123935.GA21433@rei> (raw)
In-Reply-To: <55399C3A.70800@huawei.com>

Hi!
> Using test.sh in the case:
> * Change the tst_resm() followed by exit to tst_brkm and remove the exit
> * Changing the check_result() to call tst_resm TPASS and the test_failed() which is
>   called by check_result() to call tst_resm TFAIL
> * Delete the exit -1 at the end of the test and change exit to tst_exit at the
>   very end of the test

Pushed, thanks.

BTW: The test still can be cleaned up to use tst_tmpdir/tst_rmdir
     instead of creating it manually, it should stop working with
     global path to subtest binaries (the path to these is in $PATH),
     etc.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2015-04-28 12:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31  3:16 [LTP] [PATCH] syscalls/utimensat01: "chattr" command error cuibixuan
2015-04-01 14:33 ` Cyril Hrubis
     [not found]   ` <551CB5CD.5030903@huawei.com>
2015-04-02  8:33     ` [LTP] [PATCH v2] " Cyril Hrubis
     [not found]       ` <552D1041.9010103@huawei.com>
2015-04-22 14:04         ` [LTP] [PATCH v4 1/2] syscalls/utimensat01: Use test.sh library for test case Cyril Hrubis
     [not found]           ` <55399C3A.70800@huawei.com>
2015-04-28 12:39             ` Cyril Hrubis [this message]
     [not found]       ` <552D112E.4040104@huawei.com>
2015-04-22 14:06         ` [LTP] [PATCH v4 2/2] syscalls/utimensat01: "chattr" command error Cyril Hrubis
     [not found]           ` <55399C8E.40608@huawei.com>
2015-04-28 12:39             ` [LTP] [PATCH v5 " Cyril Hrubis
     [not found]               ` <55402B94.9010407@huawei.com>
2015-05-04 11:35                 ` [LTP] [PATCH v6 " Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150428123935.GA21433@rei \
    --to=chrubis@suse.cz \
    --cc=cuibixuan@huawei.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=zhanyongming@huawei.com \
    --cc=zhuyanpeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.