From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030252AbbD1Pmb (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Apr 2015 11:42:31 -0400
Received: from mga11.intel.com ([192.55.52.93]:22852 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S965660AbbD1Pm3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Apr 2015 11:42:29 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,664,1422950400"; 
   d="scan'208";a="563133454"
Date: Tue, 28 Apr 2015 11:42:27 -0400
From: Matthew Wilcox <willy@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dan Williams <dan.j.williams@intel.com>, Neil Brown <neilb@suse.de>,
        linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
        Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices
Message-ID: <20150428154227.GC4003@linux.intel.com>
References: <20150418013256.25237.96403.stgit@dwillia2-desk3.amr.corp.intel.com>
 <20150418013655.25237.41353.stgit@dwillia2-desk3.amr.corp.intel.com>
 <20150428130104.GE30852@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150428130104.GE30852@infradead.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 28, 2015 at 06:01:04AM -0700, Christoph Hellwig wrote:
> Please don't add any of the nd-specific hacks into the pmem driver.
> The rw_bytes functionality already is provided by the existing block
> level ->rw_page method which pmem already implements, and any sort
> of bus locking for different access methods should be in the bus
> glue, not in pmem.c

->rw_page only lets you do an entire page, not a range of bytes within
a page.