Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function

From: Felipe Balbi <balbi@ti.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Felipe Balbi <balbi@ti.com>,
	David Cohen <david.a.cohen@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Baolu Lu <baolu.lu@linux.intel.com>,
	Paul Bolle <pebolle@tiscali.nl>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function
Date: Tue, 28 Apr 2015 12:22:51 -0500	[thread overview]
Message-ID: <20150428172251.GO18263@saruman.tx.rr.com> (raw)
In-Reply-To: <1430227486-225197-7-git-send-email-heikki.krogerus@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On Tue, Apr 28, 2015 at 04:24:41PM +0300, Heikki Krogerus wrote:
> So it can be called from other places later.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Acked-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
>  drivers/usb/dwc3/core.c | 46 ++++++++++++++++++++++++++++++----------------
>  1 file changed, 30 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 104b236..921f181 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -117,6 +117,33 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc)
>  }
>  
>  /**
> + * dwc3_soft_reset - Issue soft reset
> + * @dwc: Pointer to our controller context structure
> + */
> +static int dwc3_soft_reset(struct dwc3 *dwc)

I don't see this being called anywhere else in your series and I would
really like to know when we would need to reset the core again ?

I don't oppose to having this split to own function because I rather
like how it looks, but I don't want to reset the IP needlessly either.

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]