From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753721AbbD2P1i (ORCPT ); Wed, 29 Apr 2015 11:27:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33935 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbbD2P1g (ORCPT ); Wed, 29 Apr 2015 11:27:36 -0400 Date: Wed, 29 Apr 2015 17:26:33 +0200 From: Jiri Olsa To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , linux-kernel@vger.kernel.org, David Ahern , Frederic Weisbecker , Namhyung Kim , Stephane Eranian Subject: Re: [PATCH V3 05/25] perf tools: Hit all build ids when AUX area tracing Message-ID: <20150429152633.GE7822@krava.redhat.com> References: <1429903807-20559-1-git-send-email-adrian.hunter@intel.com> <1429903807-20559-6-git-send-email-adrian.hunter@intel.com> <20150428124532.GC22258@krava.redhat.com> <5540CD63.5080503@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5540CD63.5080503@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2015 at 03:24:03PM +0300, Adrian Hunter wrote: > On 28/04/15 15:45, Jiri Olsa wrote: > > On Fri, Apr 24, 2015 at 10:29:47PM +0300, Adrian Hunter wrote: > >> We need to include all buildids when a perf.data > >> file contains AUX area tracing data because we > >> do not decode the trace for that purpose because > >> it would take too long. > >> > >> Signed-off-by: Adrian Hunter > >> --- > >> tools/perf/builtin-buildid-list.c | 9 +++++++++ > >> tools/perf/builtin-inject.c | 8 +++++++- > >> tools/perf/builtin-record.c | 10 +++++++++- > >> 3 files changed, 25 insertions(+), 2 deletions(-) > >> > >> diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c > >> index feb420f..9fe93c8 100644 > >> --- a/tools/perf/builtin-buildid-list.c > >> +++ b/tools/perf/builtin-buildid-list.c > >> @@ -69,6 +69,15 @@ static int perf_session__list_build_ids(bool force, bool with_hits) > >> session = perf_session__new(&file, false, &build_id__mark_dso_hit_ops); > >> if (session == NULL) > >> return -1; > >> + > >> + /* > >> + * We take all buildids when the file contains AUX area tracing data > >> + * because we do not decode the trace because it would take too long. > >> + */ > >> + if (!perf_data_file__is_pipe(&file) && > >> + perf_header__has_feat(&session->header, HEADER_AUXTRACE)) > >> + with_hits = false; > > > > when there's auxtrace in the perf.data, all the dsos would have > > hits (as per builtin-record.c change below) and be display anyway, > > so it seems we dont need this hunk? > > When there's auxtrace in the perf.data file, then all dsos would be recorded > with build ids in the build_id section. > > This hunk causes: > 1) no session processing to find hits ok, missed the perf_session__process_events call in here :-\ jirka