From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbbD3Rhn (ORCPT ); Thu, 30 Apr 2015 13:37:43 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46726 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbbD3Rhk (ORCPT ); Thu, 30 Apr 2015 13:37:40 -0400 Date: Thu, 30 Apr 2015 19:37:35 +0200 From: Pavel Machek To: grygorii.strashko@linaro.org Cc: "Rafael J. Wysocki" , Len Brown , linux-pm@vger.kernel.org, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , Nishanth Menon , Kevin Hilman , Santosh Shilimkar Subject: Re: [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it Message-ID: <20150430173735.GC23579@amd> References: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2015-04-27 21:24:29, grygorii.strashko@linaro.org wrote: > From: Grygorii Strashko > > While working on suspend-to-disk functionality on TI dra7-evm (DRA7xx SoC) > i've found that the most common problem I have to dial with is absence > of corresponding PM callbacks in drivers and, in particular, noirq callbacks. > So, I've fixed one driver first > commit 6248015d6867 "ARM: omap-device: add missed callback for suspend-to-disk" > but then found another one which need to be fixed too (omap_l3_noc.c). > At this moment I decided to make my life easier and added new macro > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS using the same approach as for the existing > SET_SYSTEM_SLEEP_PM_OPS macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS: defined for CONFIG_PM_SLEEP and > assigns ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Further two patches reuse this newly introduced macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, defined for CONFIG_PM_SLEEP, will > point ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Cc: Tony Lindgren > Cc: Nishanth Menon > Cc: Kevin Hilman > Cc: Santosh Shilimkar Looks ok to me. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Thu, 30 Apr 2015 19:37:35 +0200 Subject: [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it In-Reply-To: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org> References: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org> Message-ID: <20150430173735.GC23579@amd> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon 2015-04-27 21:24:29, grygorii.strashko at linaro.org wrote: > From: Grygorii Strashko > > While working on suspend-to-disk functionality on TI dra7-evm (DRA7xx SoC) > i've found that the most common problem I have to dial with is absence > of corresponding PM callbacks in drivers and, in particular, noirq callbacks. > So, I've fixed one driver first > commit 6248015d6867 "ARM: omap-device: add missed callback for suspend-to-disk" > but then found another one which need to be fixed too (omap_l3_noc.c). > At this moment I decided to make my life easier and added new macro > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS using the same approach as for the existing > SET_SYSTEM_SLEEP_PM_OPS macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS: defined for CONFIG_PM_SLEEP and > assigns ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Further two patches reuse this newly introduced macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, defined for CONFIG_PM_SLEEP, will > point ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Cc: Tony Lindgren > Cc: Nishanth Menon > Cc: Kevin Hilman > Cc: Santosh Shilimkar Looks ok to me. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html