From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 for-next 02/33] IB/core: Add kref to IB devices Date: Thu, 30 Apr 2015 11:52:52 -0600 Message-ID: <20150430175252.GB32666@obsidianresearch.com> References: <9f65de5e-ed5f-48d2-bff2-03ffbe4f4876@CMEXHTCAS2.ad.emulex.com> <553DF294.4070507@mellanox.com> <553F931F.6000302@mellanox.com> <20150428174312.GB5497@obsidianresearch.com> <5540F8F4.5010906@dev.mellanox.co.il> <20150429164847.GA12781@obsidianresearch.com> <5541E5ED.7000606@mellanox.com> <1828884A29C6694DAF28B7E6B8A82373A8FC929B@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373A8FC929B-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: Matan Barak , Or Gerlitz , Somnath Kotur , Roland Dreier , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Thu, Apr 30, 2015 at 04:56:13PM +0000, Hefty, Sean wrote: > I still don't even buy that a cache is needed at all. The RDMA CM > can accept as input UDP/IP addresses. RoCEv2 puts UDP/IP addresses > on the wire. Why should there be a conversion from an IP address to > a GID to get back to the same IP address? Why aren't IP addresses > passed directly to the drivers? Just change how the RDMA CM > associates an IP address with the RDMA device. I feel it looks overdesigned too.. But, how could RDMA CM work? Inbound CM messages will be filtered if the IP is not in the HW GID table? How could UD work? This current scheme is just so ugly, there are so many wonky possibilities. What happens if I remove an IP and then add a new one? The GID index will eventually be re-used, and QPs bound to that gid index will silently change source IPs. Horrible. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html