From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbbEBSi0 (ORCPT ); Sat, 2 May 2015 14:38:26 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44932 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbbEBSiZ (ORCPT ); Sat, 2 May 2015 14:38:25 -0400 Date: Sat, 2 May 2015 20:38:22 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: vikas.shivappa@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, matt.fleming@intel.com, will.auld@intel.com, peter.zijlstra@intel.com, h.peter.anvin@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 2/7] x86/intel_rdt: Adds support for Class of service management Message-ID: <20150502183822.GG3007@worktop.Skamania.guest> References: <1430530601-16319-1-git-send-email-vikas.shivappa@linux.intel.com> <1430530601-16319-3-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430530601-16319-3-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2015 at 06:36:36PM -0700, Vikas Shivappa wrote: > +static inline bool cat_supported(struct cpuinfo_x86 *c) Is search and replace really that hard? > +/* > +* Called with the rdt_group_mutex held. > +*/ Whitespace damaged and pointless comment. > +static int rdt_free_closid(struct intel_rdt *ir) > +{ > + superfluous whitespace > + lockdep_assert_held(&rdt_group_mutex); > + > + WARN_ON(!ccmap[ir->clos].cgrp_count); > + ccmap[ir->clos].cgrp_count--; > + if (!ccmap[ir->clos].cgrp_count) > + clear_bit(ir->clos, rdtss_info.closmap); > + > + return 0; > +} These patches really are very sloppy..