From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Westfield Subject: Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant Date: Sat, 2 May 2015 16:58:09 -0700 Message-ID: <20150502235800.GC27804@kwestfie-linux.qualcomm.com> References: <1430414148-10869-1-git-send-email-srinivas.kandagatla@linaro.org> <1430414244-11168-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1430414244-11168-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srinivas Kandagatla Cc: Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Kenneth Westfield , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote: > Some LPASS integrations like on APQ8016 do not have OSR clk, so adding > no osr clk bit would allow such integrations to use lpass driver. Going forward, as the code is generalized, perhaps having an enable flag for each clock, rather than a flag that negates an existing clock? Or checking that the clock pointer is NULL after probing would be the indication? > sound/soc/qcom/lpass-cpu.c | 49 +++++++++++++++++++++++++++++----------------- > sound/soc/qcom/lpass.h | 2 ++ > 2 files changed, 33 insertions(+), 18 deletions(-) -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753114AbbEBX6T (ORCPT ); Sat, 2 May 2015 19:58:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50378 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752575AbbEBX6K (ORCPT ); Sat, 2 May 2015 19:58:10 -0400 Date: Sat, 2 May 2015 16:58:09 -0700 From: Kenneth Westfield To: Srinivas Kandagatla Cc: Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Kenneth Westfield , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Subject: Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant Message-ID: <20150502235800.GC27804@kwestfie-linux.qualcomm.com> Mail-Followup-To: Srinivas Kandagatla , Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org References: <1430414148-10869-1-git-send-email-srinivas.kandagatla@linaro.org> <1430414244-11168-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430414244-11168-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote: > Some LPASS integrations like on APQ8016 do not have OSR clk, so adding > no osr clk bit would allow such integrations to use lpass driver. Going forward, as the code is generalized, perhaps having an enable flag for each clock, rather than a flag that negates an existing clock? Or checking that the clock pointer is NULL after probing would be the indication? > sound/soc/qcom/lpass-cpu.c | 49 +++++++++++++++++++++++++++++----------------- > sound/soc/qcom/lpass.h | 2 ++ > 2 files changed, 33 insertions(+), 18 deletions(-) -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project