From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752093AbbEDFVB (ORCPT ); Mon, 4 May 2015 01:21:01 -0400 Received: from mga02.intel.com ([134.134.136.20]:5415 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbbEDFUy (ORCPT ); Mon, 4 May 2015 01:20:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,364,1427785200"; d="scan'208";a="723097930" Date: Mon, 4 May 2015 10:51:38 +0530 From: Vinod Koul To: Nicholas Mc Guire Cc: David Woodhouse , Brian Norris , Laurent Pinchart , Kuninori Morimoto , Wolfram Sang , Arnd Bergmann , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment Message-ID: <20150504052138.GX3521@localhost> References: <1430553430-21396-1-git-send-email-hofrat@osadl.org> <1430553430-21396-4-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430553430-21396-4-git-send-email-hofrat@osadl.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > CodingStyle fix only - align function parameters to opening (. > This doesnt look any better to me... -- ~Vinod > Signed-off-by: Nicholas Mc Guire > --- > > Patch was compile tested with ap325rxa_defconfig (implies > CONFIG_MTD_NAND_SH_FLCTL=y) > > Patch is against 4.1-rc1 (localversion-next is -next-20150501) > > drivers/mtd/nand/sh_flctl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index ffda530..2078c4d 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int rlen, int offset) > > /* initiate DMA transfer */ > if (flctl->chan_fifo0_rx && rlen >= 32 && > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > - goto convert; /* DMA success */ > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > + goto convert; /* DMA success */ > > /* do polling transfer */ > for (i = 0; i < len_4align; i++) { > @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, int rlen, > > /* initiate DMA transfer */ > if (flctl->chan_fifo0_tx && rlen >= 32 && > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > - return; /* DMA success */ > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > + return; /* DMA success */ > > /* do polling transfer */ > for (i = 0; i < len_4align; i++) { > -- > 1.7.10.4 > -- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yp8oc-0003kg-9V for linux-mtd@lists.infradead.org; Mon, 04 May 2015 05:21:14 +0000 Date: Mon, 4 May 2015 10:51:38 +0530 From: Vinod Koul To: Nicholas Mc Guire Subject: Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment Message-ID: <20150504052138.GX3521@localhost> References: <1430553430-21396-1-git-send-email-hofrat@osadl.org> <1430553430-21396-4-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430553430-21396-4-git-send-email-hofrat@osadl.org> Cc: Laurent Pinchart , Kuninori Morimoto , Arnd Bergmann , Wolfram Sang , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > CodingStyle fix only - align function parameters to opening (. > This doesnt look any better to me... -- ~Vinod > Signed-off-by: Nicholas Mc Guire > --- > > Patch was compile tested with ap325rxa_defconfig (implies > CONFIG_MTD_NAND_SH_FLCTL=y) > > Patch is against 4.1-rc1 (localversion-next is -next-20150501) > > drivers/mtd/nand/sh_flctl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index ffda530..2078c4d 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int rlen, int offset) > > /* initiate DMA transfer */ > if (flctl->chan_fifo0_rx && rlen >= 32 && > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > - goto convert; /* DMA success */ > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > + goto convert; /* DMA success */ > > /* do polling transfer */ > for (i = 0; i < len_4align; i++) { > @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, int rlen, > > /* initiate DMA transfer */ > if (flctl->chan_fifo0_tx && rlen >= 32 && > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > - return; /* DMA success */ > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > + return; /* DMA success */ > > /* do polling transfer */ > for (i = 0; i < len_4align; i++) { > -- > 1.7.10.4 > --