From: Mark Brown <broonie@kernel.org>
To: Sergej Sawazki <ce3a@gmx.de>
Cc: ckeepax@opensource.wolfsonmicro.com, lars@metafoo.de,
lgirdwood@gmail.com, alsa-devel@alsa-project.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [RFC PATCH] ASoC: wm8741: Add differential mono mode support
Date: Mon, 4 May 2015 12:25:37 +0100 [thread overview]
Message-ID: <20150504112537.GA15510@sirena.org.uk> (raw)
In-Reply-To: <1430504037-7170-1-git-send-email-ce3a@gmx.de>
[-- Attachment #1.1: Type: text/plain, Size: 809 bytes --]
On Fri, May 01, 2015 at 08:13:57PM +0200, Sergej Sawazki wrote:
> +static const struct snd_kcontrol_new wm8741_snd_controls_mono_right[] = {
> + SOC_SINGLE_TLV("Fine Playback Volume Right", WM8741_DACRLSB_ATTENUATION,
> + 1, 255, 1, dac_tlv_fine),
> + SOC_SINGLE_TLV("Playback Volume Right", WM8741_DACRMSB_ATTENUATION,
> + 0, 511, 1, dac_tlv),
> +};
Please follow the control naming standard in ControlNames.txt: all
volume controls must have Volume as the last word in the name.
> .name = "wm8741",
> .playback = {
> .stream_name = "Playback",
> - .channels_min = 2, /* Mono modes not yet supported */
> + .channels_min = 1,
> .channels_max = 2,
This should be varying with the platform data: in the mono modes we
can't do stereo and I suspect the stereo modes may have issues with
mono.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-05-04 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 18:13 [RFC PATCH] ASoC: wm8741: Add differential mono mode support Sergej Sawazki
2015-05-04 8:02 ` Charles Keepax
2015-05-04 11:25 ` Mark Brown [this message]
2015-05-04 19:03 ` Sergej Sawazki
2015-05-05 11:22 ` Mark Brown
2015-05-05 12:19 ` Sergej Sawazki
2015-05-05 13:57 ` Mark Brown
2015-05-05 14:07 ` Sergej Sawazki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504112537.GA15510@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ce3a@gmx.de \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.