From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbbEEAmf (ORCPT ); Mon, 4 May 2015 20:42:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56221 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbbEEAm2 (ORCPT ); Mon, 4 May 2015 20:42:28 -0400 Date: Tue, 5 May 2015 02:42:24 +0200 From: "Luis R. Rodriguez" To: Borislav Petkov Cc: "Luis R. Rodriguez" , mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, daniel.vetter@intel.com, airlied@linux.ie, dledford@redhat.com, awalls@md.metrocast.net, syrjala@sci.fi, luto@amacapital.net, mst@redhat.com, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Christoph Lameter , Kyle McMartin , Juergen Gross , Daniel Vetter , Dave Airlie , Bjorn Helgaas , x86@kernel.org Subject: Re: [PATCH v5 2/6] x86/mm/pat: redefine pat_enabled Message-ID: <20150505004224.GG5622@wotan.suse.de> References: <1430425520-22275-1-git-send-email-mcgrof@do-not-panic.com> <1430425520-22275-3-git-send-email-mcgrof@do-not-panic.com> <20150504152208.GG4096@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150504152208.GG4096@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 04, 2015 at 05:22:08PM +0200, Borislav Petkov wrote: > On Thu, Apr 30, 2015 at 01:25:16PM -0700, Luis R. Rodriguez wrote: > > diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c > > index bfef424..f094d36 100644 > > --- a/arch/x86/kernel/cpu/mtrr/main.c > > +++ b/arch/x86/kernel/cpu/mtrr/main.c > > @@ -556,7 +556,7 @@ int arch_phys_wc_add(unsigned long base, unsigned long size) > > { > > int ret; > > > > - if (pat_enabled || !mtrr_enabled) > > + if (pat_enabled() || !mtrr_enabled) > > What's going on here? I got a reject about mtrr_enabled which is nowhere > to be found. Am I missing a patch? Yes, the patch titled, "x86: mtrr: generalize run time disabling of MTRR" should be applied first, or ammended to fit the new style. Let me know what you prefer. > Anyway, I applied that: Great, thanks, is there a tree I can use to rebase / fetch ? Luis