From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table Date: Tue, 5 May 2015 11:45:05 +0100 Message-ID: <20150505104505.GZ4047@x1> References: <1430316005-16480-2-git-send-email-shobhit.kumar@intel.com> <1430818368-26790-1-git-send-email-shobhit.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1430818368-26790-1-git-send-email-shobhit.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shobhit Kumar Cc: linux-pwm , Jani Nikula , Samuel Ortiz , Alexandre Courbot , David Airlie , Povilas Staniulis , intel-gfx , linux-kernel , dri-devel , linux-gpio , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Linus Walleij List-Id: linux-gpio@vger.kernel.org VGhpcyBpcyBub3QgaG93IHdlIHN1Ym1pdCBzdWJzZXF1ZW50IHBhdGNoLXNldHMuCgpQbGVhc2Ug c3VibWl0IHRoZW0gYXMgYSB3aG9sZSwgc2VwZXJhdGVseSBmcm9tIHRoZSBmaXJzdCBzdWJtaXNz aW9uCmFuZCB3aXRoIHZlcnNpb25pbmcgaW5mb3JtYXRpb24gaS5lLiBbUEFUQ0ggdjIgWC9ZXSBT dHVmZiAuLi4KCj4gSW4gY2FzZSB3ZSB1bmxvYWQgYW5kIGxvYWQgYSBkcml2ZXIgbW9kdWxlIGFn YWluIHRoYXQgaXMgcmVnaXN0ZXJpbmcgYQo+IGxvb2t1cCB0YWJsZSwgd2l0aG91dCB0aGlzIGl0 IHdpbGwgcmVzdWx0IGluIG11bHRpcGxlIGVudHJpZXMuIFByb3ZpZGUKPiBhbiBvcHRpb24gdG8g cmVtb3ZlIHRoZSBsb29rdXAgdGFibGUgb24gZHJpdmVyIHVubG9hZAo+IAo+IHYyOiBDY2luZyBt YWludGFpbmVycwo+IHYzOiBDb3JyZWN0IHRoZSBzdWJqZWN0IGxpbmUgKExlZSBqb25lcykKCkNo YW5nZSBsb2dzIHNob3VsZCBnbyB1bmRlcm5ldGggdGhlICctLS0nIGFuZCBhYm92ZSB0aGUgZGlm ZnN0YXQgZm91bmQKYmVsb3cuCgo+IENjOiBTYW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVs LmNvbT4KPiBDYzogTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgo+IENj OiBBbGV4YW5kcmUgQ291cmJvdCA8Z251cm91QGdtYWlsLmNvbT4KPiBDYzogVGhpZXJyeSBSZWRp bmcgPHRoaWVycnkucmVkaW5nQGdtYWlsLmNvbT4KPiBSZXZpZXdlZC1ieTogQWxleGFuZHJlIENv dXJib3QgPGFjb3VyYm90QG52aWRpYS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU2hvYmhpdCBLdW1h ciA8c2hvYmhpdC5rdW1hckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3Bpby9ncGlvbGli LmMgICAgICAgfCAxMyArKysrKysrKysrKysrCj4gIGluY2x1ZGUvbGludXgvZ3Bpby9tYWNoaW5l LmggfCAgMSArCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwaW8vZ3Bpb2xpYi5jIGIvZHJpdmVycy9ncGlvL2dwaW9saWIuYwo+ IGluZGV4IDU5ZWFhMjMuLjI0MjBhZjkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncGlvL2dwaW9s aWIuYwo+ICsrKyBiL2RyaXZlcnMvZ3Bpby9ncGlvbGliLmMKPiBAQCAtMTY1OCw2ICsxNjU4LDE5 IEBAIHZvaWQgZ3Bpb2RfYWRkX2xvb2t1cF90YWJsZShzdHJ1Y3QgZ3Bpb2RfbG9va3VwX3RhYmxl ICp0YWJsZSkKPiAgCW11dGV4X3VubG9jaygmZ3Bpb19sb29rdXBfbG9jayk7Cj4gIH0KPiAgCj4g Ky8qKgo+ICsgKiBncGlvZF9yZW1vdmVfbG9va3VwX3RhYmxlKCkgLSB1bnJlZ2lzdGVyIEdQSU8g ZGV2aWNlIGNvbnN1bWVycwo+ICsgKiBAdGFibGU6IHRhYmxlIG9mIGNvbnN1bWVycyB0byB1bnJl Z2lzdGVyCj4gKyAqLwo+ICt2b2lkIGdwaW9kX3JlbW92ZV9sb29rdXBfdGFibGUoc3RydWN0IGdw aW9kX2xvb2t1cF90YWJsZSAqdGFibGUpCj4gK3sKPiArCW11dGV4X2xvY2soJmdwaW9fbG9va3Vw X2xvY2spOwo+ICsKPiArCWxpc3RfZGVsKCZ0YWJsZS0+bGlzdCk7Cj4gKwo+ICsJbXV0ZXhfdW5s b2NrKCZncGlvX2xvb2t1cF9sb2NrKTsKPiArfQo+ICsKPiAgc3RhdGljIHN0cnVjdCBncGlvX2Rl c2MgKm9mX2ZpbmRfZ3BpbyhzdHJ1Y3QgZGV2aWNlICpkZXYsIGNvbnN0IGNoYXIgKmNvbl9pZCwK PiAgCQkJCSAgICAgIHVuc2lnbmVkIGludCBpZHgsCj4gIAkJCQkgICAgICBlbnVtIGdwaW9fbG9v a3VwX2ZsYWdzICpmbGFncykKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9ncGlvL21hY2hp bmUuaCBiL2luY2x1ZGUvbGludXgvZ3Bpby9tYWNoaW5lLmgKPiBpbmRleCBlMjcwNjE0Li5jMGQ3 MTJkIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvZ3Bpby9tYWNoaW5lLmgKPiArKysgYi9p bmNsdWRlL2xpbnV4L2dwaW8vbWFjaGluZS5oCj4gQEAgLTU3LDUgKzU3LDYgQEAgc3RydWN0IGdw aW9kX2xvb2t1cF90YWJsZSB7Cj4gIH0KPiAgCj4gIHZvaWQgZ3Bpb2RfYWRkX2xvb2t1cF90YWJs ZShzdHJ1Y3QgZ3Bpb2RfbG9va3VwX3RhYmxlICp0YWJsZSk7Cj4gK3ZvaWQgZ3Bpb2RfcmVtb3Zl X2xvb2t1cF90YWJsZShzdHJ1Y3QgZ3Bpb2RfbG9va3VwX3RhYmxlICp0YWJsZSk7Cj4gIAo+ICAj ZW5kaWYgLyogX19MSU5VWF9HUElPX01BQ0hJTkVfSCAqLwoKLS0gCkxlZSBKb25lcwpMaW5hcm8g U1RNaWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4g c291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3 aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757876AbbEEKpS (ORCPT ); Tue, 5 May 2015 06:45:18 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36207 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbbEEKpL (ORCPT ); Tue, 5 May 2015 06:45:11 -0400 Date: Tue, 5 May 2015 11:45:05 +0100 From: Lee Jones To: Shobhit Kumar Cc: intel-gfx , linux-kernel , linux-gpio , linux-pwm , dri-devel , Linus Walleij , Alexandre Courbot , Daniel Vetter , David Airlie , Samuel Ortiz , Thierry Reding , Jani Nikula , Povilas Staniulis , Chih-Wei Huang Subject: Re: [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table Message-ID: <20150505104505.GZ4047@x1> References: <1430316005-16480-2-git-send-email-shobhit.kumar@intel.com> <1430818368-26790-1-git-send-email-shobhit.kumar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1430818368-26790-1-git-send-email-shobhit.kumar@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is not how we submit subsequent patch-sets. Please submit them as a whole, seperately from the first submission and with versioning information i.e. [PATCH v2 X/Y] Stuff ... > In case we unload and load a driver module again that is registering a > lookup table, without this it will result in multiple entries. Provide > an option to remove the lookup table on driver unload > > v2: Ccing maintainers > v3: Correct the subject line (Lee jones) Change logs should go underneth the '---' and above the diffstat found below. > Cc: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Reviewed-by: Alexandre Courbot > Signed-off-by: Shobhit Kumar > --- > drivers/gpio/gpiolib.c | 13 +++++++++++++ > include/linux/gpio/machine.h | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 59eaa23..2420af9 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table) > mutex_unlock(&gpio_lookup_lock); > } > > +/** > + * gpiod_remove_lookup_table() - unregister GPIO device consumers > + * @table: table of consumers to unregister > + */ > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) > +{ > + mutex_lock(&gpio_lookup_lock); > + > + list_del(&table->list); > + > + mutex_unlock(&gpio_lookup_lock); > +} > + > static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, > unsigned int idx, > enum gpio_lookup_flags *flags) > diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h > index e270614..c0d712d 100644 > --- a/include/linux/gpio/machine.h > +++ b/include/linux/gpio/machine.h > @@ -57,5 +57,6 @@ struct gpiod_lookup_table { > } > > void gpiod_add_lookup_table(struct gpiod_lookup_table *table); > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); > > #endif /* __LINUX_GPIO_MACHINE_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog