From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v7 08/10] ixgbe: enable rx queue interrupts
 for both PF and VF
Date: Tue, 5 May 2015 11:36:11 -0700
Message-ID: <20150505113611.1359e2d8@urahara>
References: <1425012976-10173-1-git-send-email-cunming.liang@intel.com>
 <1430804386-28949-1-git-send-email-cunming.liang@intel.com>
 <1430804386-28949-9-git-send-email-cunming.liang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Cunming Liang <cunming.liang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1430804386-28949-9-git-send-email-cunming.liang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Tue,  5 May 2015 13:39:44 +0800
Cunming Liang <cunming.liang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:

>  
> +	/* set max interrupt vfio request */
> +	if (pci_dev->intr_handle.vec_en) {
> +		pci_dev->intr_handle.max_intr = hw->mac.max_rx_queues +
> +			IXGBEVF_MAX_OTHER_INTR;
> +		pci_dev->intr_handle.intr_vec =
> +			rte_zmalloc("intr_vec",
> +				    hw->mac.max_rx_queues * sizeof(int), 0);
> +	

Since MSI-X vectors are limited on many hardware platforms, this whole API
should be changed so that max_intr is based on number of rx_queues actually
used by the application.  That means the setup needs to move from init to configure.