All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Mc Guire <der.herr@hofr.at>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Michal Marek <mmarek@suse.cz>,
	cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] Coccinelle: Check for return not matching function signature
Date: Tue, 5 May 2015 18:00:35 +0200	[thread overview]
Message-ID: <20150505160035.GB9724@opentech.at> (raw)
In-Reply-To: <alpine.DEB.2.10.1505051633550.2640@hadrien>

On Tue, 05 May 2015, Julia Lawall wrote:

> > +@match@
> > +identifier f,ret;
> > +position p;
> > +type T1,T2;
> > +@@
> > +
> > +T1 f(...) {
> > + T2 ret;
> > +<+...
> > +* return@p ret
> > +;
> > +...+>
> > +}
> 
> Given the number of results, it may seem surprising, but I think that you
> are actually missing a lot of results.  Becaue you require that ret be the
> first variable that is declared in the function.  Also, you require that
> ret be an identifier.  If you want to keep the restriction about being an
> identifier, you could put:
> 
> @match exists@
> type T1,T2;
> idexpression T2 ret;
> identifier f;
> @@
> 
> T1 f(...) {
> <+...
> return@p ret;
> ...+>
> }
>

this is depressing - I now like by wrong solution even more ...
unfortunately you are right - I missed most - its now at 25146
 
> If you don't care about the identifier constraint, then you can just put
> T2 ret.  Note also the addition of exists.  There is a problem if only one
> path has this property.  Another thing you can do is the following:
> 
> @match exists@
> type T1,T2;
  idexpression T1 ok;
> idexpression T2 ret;
> identifier f;
  position p;
> @@
> 
> T1 f(...) {
> <+...
> (
> return ok;
> |
> return@p ret;
> )
> ...+>
> }
> 
> Then Coccinelle will find the cases where the types are wrong, rather than
> requiring a test in python.
> 
> (I haven't tested any of this)

also works - I had naively expected this to be faster - but it does not
seem to be.

will check results did not expect 10% of the kernel functions
to have missmatching return types in atleast one of their paths.

thx!
hofrat

WARNING: multiple messages have this Message-ID (diff)
From: der.herr@hofr.at (Nicholas Mc Guire)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH RFC] Coccinelle: Check for return not matching function	signature
Date: Tue, 5 May 2015 18:00:35 +0200	[thread overview]
Message-ID: <20150505160035.GB9724@opentech.at> (raw)
In-Reply-To: <alpine.DEB.2.10.1505051633550.2640@hadrien>

On Tue, 05 May 2015, Julia Lawall wrote:

> > + at match@
> > +identifier f,ret;
> > +position p;
> > +type T1,T2;
> > +@@
> > +
> > +T1 f(...) {
> > + T2 ret;
> > +<+...
> > +* return at p ret
> > +;
> > +...+>
> > +}
> 
> Given the number of results, it may seem surprising, but I think that you
> are actually missing a lot of results.  Becaue you require that ret be the
> first variable that is declared in the function.  Also, you require that
> ret be an identifier.  If you want to keep the restriction about being an
> identifier, you could put:
> 
> @match exists@
> type T1,T2;
> idexpression T2 ret;
> identifier f;
> @@
> 
> T1 f(...) {
> <+...
> return at p ret;
> ...+>
> }
>

this is depressing - I now like by wrong solution even more ...
unfortunately you are right - I missed most - its now at 25146
 
> If you don't care about the identifier constraint, then you can just put
> T2 ret.  Note also the addition of exists.  There is a problem if only one
> path has this property.  Another thing you can do is the following:
> 
> @match exists@
> type T1,T2;
  idexpression T1 ok;
> idexpression T2 ret;
> identifier f;
  position p;
> @@
> 
> T1 f(...) {
> <+...
> (
> return ok;
> |
> return at p ret;
> )
> ...+>
> }
> 
> Then Coccinelle will find the cases where the types are wrong, rather than
> requiring a test in python.
> 
> (I haven't tested any of this)

also works - I had naively expected this to be faster - but it does not
seem to be.

will check results did not expect 10% of the kernel functions
to have missmatching return types in atleast one of their paths.

thx!
hofrat

  reply	other threads:[~2015-05-05 16:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 10:12 [PATCH RFC] Coccinelle: Check for return not matching function signature Nicholas Mc Guire
2015-05-05 10:12 ` [Cocci] " Nicholas Mc Guire
2015-05-05 12:32 ` SF Markus Elfring
2015-05-05 12:32   ` [Cocci] " SF Markus Elfring
2015-05-05 13:04   ` Nicholas Mc Guire
2015-05-05 13:04     ` [Cocci] " Nicholas Mc Guire
2015-05-05 13:29     ` Julia Lawall
2015-05-05 13:29       ` Julia Lawall
2015-05-05 13:45     ` SF Markus Elfring
2015-05-05 13:45       ` [Cocci] " SF Markus Elfring
2015-05-05 14:40 ` Julia Lawall
2015-05-05 14:40   ` [Cocci] " Julia Lawall
2015-05-05 16:00   ` Nicholas Mc Guire [this message]
2015-05-05 16:00     ` Nicholas Mc Guire
2015-05-05 21:24     ` Julia Lawall
2015-05-05 21:24       ` [Cocci] " Julia Lawall
2015-05-08  6:59       ` Nicholas Mc Guire
2015-05-08  6:59         ` [Cocci] " Nicholas Mc Guire
2015-05-05 16:25   ` SF Markus Elfring
2015-05-05 16:25     ` [Cocci] " SF Markus Elfring
2015-05-05 21:46     ` Julia Lawall
2015-05-05 21:46       ` [Cocci] " Julia Lawall
2015-05-06  7:15 ` SF Markus Elfring
2015-05-06  7:15   ` [Cocci] " SF Markus Elfring
2015-05-06  7:15   ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150505160035.GB9724@opentech.at \
    --to=der.herr@hofr.at \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=hofrat@osadl.org \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.