From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings Date: Tue, 5 May 2015 18:12:52 +0100 Message-ID: <20150505171252.GI22845@sirena.org.uk> References: <20150504121209.GM15510@sirena.org.uk> <20150505105714.GA22845@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v0UO8vuVPXJ4JTyq" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , Rob Herring , Arnd Bergmann , Nishanth Menon , Mike Turquette , Stephen Boyd , Linaro Kernel Mailman List , "linux-pm@vger.kernel.org" , Grant Likely , "olof@lixom.net" , Sudeep Holla , "devicetree@vger.kernel.org" , Viswanath Puttagunta , Lucas Stach , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Thomas Abraham , Abhilash Kesavan , Kevin Hilman , santosh List-Id: devicetree@vger.kernel.org --v0UO8vuVPXJ4JTyq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 05, 2015 at 05:13:33PM +0530, Viresh Kumar wrote: > On 5 May 2015 at 16:27, Mark Brown wrote: > > No, it doesn't - you're not answering the question about what this is > > for. > I don't know how this information will be used finally. Probably the > platform driver will do the configuration based on the volt-cur pair. I don't think we should be defining a binding without understanding what it is supposed to mean. =20 > - opp-microamp: current in micro Amperes. It can contain entries for mul= tiple > - regulators. > + regulators. This can be referenced (along with voltage and freqency) w= hile > + programming the regulator. This still doesn't say what the value is supposed to mean which means it's not possible for someone to write generic code which handles the binding - saying that people can reference the value doesn't tell them how to interpret it. A limit? A nominal constant draw value? A value to regulate to? Those are all different things expressed as a current. --v0UO8vuVPXJ4JTyq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVSPoUAAoJECTWi3JdVIfQaAcH/1csXdJjh1PCxKLq90jlOIfR F936bn9idfw8ojWyLPEQi3z8DUaFwwK4fkKaj4bOA7H8cevtamCfqTByXQo4V9zx MHdrO9l4CtlWv4dBa+unnVbCtMCzsyW7KYba8DKJuaoX2Nxl9R5TcB/vBnmhGrmg jBDw4w7hQOgNb4Uzj/SensRUgmOe+74fFUxvmu4fNdl6qAIbaOn03VhdPdbLLrnt LiLyeUlSp9eMhvYp7B4ITTU5KUNi5VkRm/akWVWUDgKXqD/2Y8ng6hqOvrksttCo OOm973yS4767qjKZrO4PA4zHoMt2U0jMwq8N8v7RHupDLeT/BnHod4zcYaDvYlU= =hI/C -----END PGP SIGNATURE----- --v0UO8vuVPXJ4JTyq-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Tue, 5 May 2015 18:12:52 +0100 Subject: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings In-Reply-To: References: <20150504121209.GM15510@sirena.org.uk> <20150505105714.GA22845@sirena.org.uk> Message-ID: <20150505171252.GI22845@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 05, 2015 at 05:13:33PM +0530, Viresh Kumar wrote: > On 5 May 2015 at 16:27, Mark Brown wrote: > > No, it doesn't - you're not answering the question about what this is > > for. > I don't know how this information will be used finally. Probably the > platform driver will do the configuration based on the volt-cur pair. I don't think we should be defining a binding without understanding what it is supposed to mean. > - opp-microamp: current in micro Amperes. It can contain entries for multiple > - regulators. > + regulators. This can be referenced (along with voltage and freqency) while > + programming the regulator. This still doesn't say what the value is supposed to mean which means it's not possible for someone to write generic code which handles the binding - saying that people can reference the value doesn't tell them how to interpret it. A limit? A nominal constant draw value? A value to regulate to? Those are all different things expressed as a current. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: