From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756274AbbEFHp0 (ORCPT ); Wed, 6 May 2015 03:45:26 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58517 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756149AbbEFHpV (ORCPT ); Wed, 6 May 2015 03:45:21 -0400 Date: Wed, 6 May 2015 00:45:18 -0700 From: Stephen Boyd To: Krzysztof Kozlowski Cc: Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] clk: bindings: Fix assigned-clock-rates property name Message-ID: <20150506074518.GA11126@codeaurora.org> References: <1430893716-1825-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430893716-1825-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06, Krzysztof Kozlowski wrote: > In documentation the "assigned-clock-parents" name was used when > describing the "assigned-clock-rates" property. > > Signed-off-by: Krzysztof Kozlowski > --- Looks right. The whole sentence could use some work though. > Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt > index 06fc6d541c89..bf5b0414dc17 100644 > --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt > +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt > @@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks > and clock frequencies. Such a configuration can be specified in a device tree > node through assigned-clocks, assigned-clock-parents and assigned-clock-rates > properties. The assigned-clock-parents property should contain a list of parent > -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents > +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates > property the list of assigned clock frequency values - corresponding to clocks This half-sentence: The assigned-clock-ratse property the list of assigned clock frequency values doesn't read correctly. Maybe the whole thing should be rewritten as: The assigned-clock-parents property should contain a list of parent clocks in the form of a phandle and clock specifier pair and the assigned-clock-rates property should contain a list of frequencies in Hz. Both these properties should correspond to the clocks listed in the assigned-clocks property. > listed in the assigned-clocks property. > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project