From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752258AbbEFIMG (ORCPT ); Wed, 6 May 2015 04:12:06 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38213 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbbEFIL4 (ORCPT ); Wed, 6 May 2015 04:11:56 -0400 Date: Wed, 6 May 2015 10:11:43 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: Vikas Shivappa , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, Matt Fleming , "Auld, Will" , peter.zijlstra@intel.com, h.peter.anvin@intel.com, "Juvva, Kanaka D" Subject: Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT Message-ID: <20150506081143.GV23123@twins.programming.kicks-ass.net> References: <1430530601-16319-1-git-send-email-vikas.shivappa@linux.intel.com> <1430530601-16319-4-git-send-email-vikas.shivappa@linux.intel.com> <20150502184610.GH3007@worktop.Skamania.guest> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 04, 2015 at 10:30:15AM -0700, Vikas Shivappa wrote: > Will fix the whitespace issues (including before return) or other possible > coding convention issues. > > It could be more of a common sense to have this in checkpatch rather that > manually having to pointing out. If you want to have fun with that go for it > though. My main objection was that your coding style is entirely inconsistent with itself. Sometimes you have a whitespace before return, sometimes you do not. Sometimes you have exit labels with locks, sometimes you do not. etc.. Pick one stick to it; although we'd all much prefer if you pick the one that's common to the kernel.