From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YpxaS-0007B3-9q
	for qemu-devel@nongnu.org; Wed, 06 May 2015 07:34:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YpxaO-0006g8-0i
	for qemu-devel@nongnu.org; Wed, 06 May 2015 07:34:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YpxaN-0006e6-Pf
	for qemu-devel@nongnu.org; Wed, 06 May 2015 07:33:55 -0400
Date: Wed, 6 May 2015 08:33:43 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20150506113343.GA17796@thinpad.lan.raisama.net>
References: <1430146411-34632-1-git-send-email-mimu@linux.vnet.ibm.com>
	<1430146411-34632-4-git-send-email-mimu@linux.vnet.ibm.com>
	<20150505131115.GO17796@thinpad.lan.raisama.net>
	<20150506114950.7ecc324d@bee>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150506114950.7ecc324d@bee>
Subject: Re: [Qemu-devel] [PATCH v6 03/17] Extend QMP command query-cpus to
 return accelerator id and model name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Mueller <mimu@linux.vnet.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Gleb Natapov <gleb@kernel.org>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>, Daniel Hansel <daniel.hansel@linux.vnet.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas Faerber <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Wed, May 06, 2015 at 11:49:50AM +0200, Michael Mueller wrote:
> On Tue, 5 May 2015 10:11:15 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
> 
> > On Mon, Apr 27, 2015 at 04:53:17PM +0200, Michael Mueller wrote:
> > > The QMP command query-cpus now additionally displays a model name and
> > > the backing accelerator. Both are omitted if the model name is not
> > > initialized.
> > > 
> > >   request:
> > >     { "execute" : "query-cpus" }
> > > 
> > >   answer:
> > >     { { "current": true,
> > >         "CPU": 0,
> > >         "model": "2827-ga2",
> > >         "halted": false,
> > >         "accel": "kvm",
> > >         "thread_id": 31917
> > >       }, ... }
> > > 
> > > Signed-off-by: Michael Mueller <mimu@linux.vnet.ibm.com>
> > > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > 
> > With the new qom-path field I submitted yesterday, this can be provided
> > as QOM properties through qom-get.
> 
> Is that really a good idea to make the object representation part of the ABI.

I believe that's the whole point of QOM properties.

> I guess there is a related discussion already somewhere. I mean not just adding
> the qom-path field, I saw that suggested patch, I mean the approach to expose the
> objects themselves...
> 
> I will try your patch of course as well...

Yes, there are two approaches we are considering to allow clients to
find the CPU QOM objects (qom-path in query-cpus, and links/aliases in
/machine/cpus). But whatever approach we use, if clients can find the
CPU objects in the QOM tree, you won't need the new fields in query-cpus
and the info can be provided using qom-get.

-- 
Eduardo