From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752034AbbEFRbM (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 May 2015 13:31:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42163 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750845AbbEFRbJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 May 2015 13:31:09 -0400
Date: Wed, 6 May 2015 19:30:35 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Borislav Petkov <bp@suse.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>, Jiri Olsa <jolsa@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: tools: Consolidate types.h
Message-ID: <20150506173035.GA19933@redhat.com>
References: <20150506165400.GA9327@redhat.com> <20150506171749.GB23762@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150506171749.GB23762@pd.tnic>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/06, Borislav Petkov wrote:
>
> On Wed, May 06, 2015 at 06:54:00PM +0200, Oleg Nesterov wrote:
> > Hi,
> >
> > I can't build the kernel after "git pull",
>
> You mean, you can't build perf tool...?

No, make bzImage fails, it can't compile arch/x86/vdso/vdso2c

>
> >
> > 	In file included from /usr/include/asm/types.h:4,
> > 			 from ./tools/include/linux/types.h:9,
> > 			 from ./include/uapi/linux/elf.h:4,
> > 			 from arch/x86/vdso/vdso2c.c:66:
> > 	./include/uapi/asm-generic/int-ll64.h:11:29: error: asm/bitsperlong.h: No such file or directory
> >
> > I am not 100% sure but it seems that this was broken by
> > d944c4eebcf4c0d5e5d9728fec110cbf0047ad7f "tools: Consolidate types.h"
> >
> > Don't we need the patch below? Or should I finally update my (very old)
> > distro which doesn't have /usr/include/asm/bitsperlong.h ?
> >
> > Oleg.
> >
> >
> > diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
> > index 275a3a8..e970320 100644
> > --- a/arch/x86/vdso/Makefile
> > +++ b/arch/x86/vdso/Makefile
> > @@ -51,7 +51,7 @@ VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
> >  $(obj)/vdso64.so.dbg: $(src)/vdso.lds $(vobjs) FORCE
> >  	$(call if_changed,vdso)
> >
> > -HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi
> > +HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi -I$(srctree)/arch/x86/include/uapi
>
> Do you have kernel-headers installed on your distro?

I have no idea ;) but I guess they were installed. many years ago.

> That's
> basically those uapi headers packaged separately. There's also "make
> headers_install" which should probably do that (haven't tried it
> though).

Perhaps. but still, if HOST_EXTRACFLAGS has -I$(srctree)/include/uapi, why
it doesn't add arch/x86/include/uapi? This doesn't look consistent in any
case.

Oleg.