From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbbEFRhL (ORCPT ); Wed, 6 May 2015 13:37:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53065 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbbEFRhI (ORCPT ); Wed, 6 May 2015 13:37:08 -0400 Date: Wed, 6 May 2015 19:37:04 +0200 From: Borislav Petkov To: Oleg Nesterov , Andy Lutomirski Cc: Rusty Russell , Jiri Olsa , linux-kernel@vger.kernel.org Subject: Re: tools: Consolidate types.h Message-ID: <20150506173703.GC23762@pd.tnic> References: <20150506165400.GA9327@redhat.com> <20150506171749.GB23762@pd.tnic> <20150506173035.GA19933@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150506173035.GA19933@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2015 at 07:30:35PM +0200, Oleg Nesterov wrote: > On 05/06, Borislav Petkov wrote: > > > > On Wed, May 06, 2015 at 06:54:00PM +0200, Oleg Nesterov wrote: > > > Hi, > > > > > > I can't build the kernel after "git pull", > > > > You mean, you can't build perf tool...? > > No, make bzImage fails, it can't compile arch/x86/vdso/vdso2c Wow, so this commit is a year old and this is the first time I see a it causing a failure. You must have a really ooold distro :-) > > > diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile > > > index 275a3a8..e970320 100644 > > > --- a/arch/x86/vdso/Makefile > > > +++ b/arch/x86/vdso/Makefile > > > @@ -51,7 +51,7 @@ VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \ > > > $(obj)/vdso64.so.dbg: $(src)/vdso.lds $(vobjs) FORCE > > > $(call if_changed,vdso) > > > > > > -HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi > > > +HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi -I$(srctree)/arch/x86/include/uapi > > > > Do you have kernel-headers installed on your distro? > > I have no idea ;) but I guess they were installed. many years ago. > > > That's > > basically those uapi headers packaged separately. There's also "make > > headers_install" which should probably do that (haven't tried it > > though). > > Perhaps. but still, if HOST_EXTRACFLAGS has -I$(srctree)/include/uapi, why > it doesn't add arch/x86/include/uapi? This doesn't look consistent in any > case. Yeah, I guess it wouldn't hurt. Andy, see quoted hunk above ^^. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --