All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Anton Arapov <arapov@gmail.com>,
	David Long <dave.long@linaro.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Ingo Molnar <mingo@kernel.org>, Jan Willeke <willeke@de.ibm.com>,
	Jim Keniston <jkenisto@us.ibm.com>,
	Mark Wielaard <mjw@redhat.com>,
	Pratyush Anand <panand@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] uprobes: Change prepare_uretprobe() to use uprobe_warn()
Date: Thu, 7 May 2015 16:02:02 +0530	[thread overview]
Message-ID: <20150507103202.GA30396@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150504124902.GA22495@redhat.com>

* Oleg Nesterov <oleg@redhat.com> [2015-05-04 14:49:02]:

> Turn the last pr_warn() in uprobes.c into uprobe_warn().
> 
> While at it:
> 
>    - s/kzalloc/kmalloc, we initialize every member of ri
> 
>    - remove the pointless comment above the obvious code
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>


Looks good to me.

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---

-- 
Thanks and Regards
Srikar Dronamraju


  reply	other threads:[~2015-05-07 10:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 12:48 [PATCH 00/10] uprobes: longjmp fixes Oleg Nesterov
2015-05-04 12:48 ` [PATCH 01/10] uprobes: Introduce get_uprobe() Oleg Nesterov
2015-05-06 13:20   ` Srikar Dronamraju
2015-05-04 12:48 ` [PATCH 02/10] uprobes: Introduce free_ret_instance() Oleg Nesterov
2015-05-06 13:22   ` Srikar Dronamraju
2015-05-04 12:48 ` [PATCH 03/10] uprobes: Send SIGILL if handle_trampoline() fails Oleg Nesterov
2015-05-06 13:30   ` Srikar Dronamraju
2015-05-04 12:49 ` [PATCH 04/10] uprobes: Change prepare_uretprobe() to use uprobe_warn() Oleg Nesterov
2015-05-07 10:32   ` Srikar Dronamraju [this message]
2015-05-04 12:49 ` [PATCH 05/10] uprobes: Change handle_trampoline() to find the next chain beforehand Oleg Nesterov
2015-05-07 10:33   ` Srikar Dronamraju
2015-05-04 12:49 ` [PATCH 06/10] uprobes: Introduce struct arch_uretprobe Oleg Nesterov
2015-05-07 10:34   ` Srikar Dronamraju
2015-05-04 12:49 ` [PATCH 07/10] uprobes/x86: Introduce arch_uretprobe_is_alive() Oleg Nesterov
2015-05-07 10:35   ` Srikar Dronamraju
2015-05-07 11:08   ` Srikar Dronamraju
2015-05-07 17:11     ` Oleg Nesterov
2015-05-08 11:30       ` Srikar Dronamraju
2015-05-10 12:21         ` Oleg Nesterov
2015-05-13  8:11           ` Srikar Dronamraju
2015-05-20 16:51             ` Oleg Nesterov
2015-05-18 12:08   ` Pratyush Anand
2015-05-20 15:51     ` Oleg Nesterov
2015-05-04 12:49 ` [PATCH 08/10] uprobes: Change handle_trampoline() to flush the frames invalidated by longjmp() Oleg Nesterov
2015-05-07 10:38   ` Srikar Dronamraju
2015-05-04 12:49 ` [PATCH 09/10] uprobes: Change prepare_uretprobe() to (try to) flush the dead frames Oleg Nesterov
2015-05-07 11:19   ` Srikar Dronamraju
2015-06-05 21:40   ` Oleg Nesterov
2015-05-04 12:49 ` [PATCH 10/10] uprobes/x86: Change arch_uretprobe_is_alive() to take !chained into account Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150507103202.GA30396@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=ananth@in.ibm.com \
    --cc=arapov@gmail.com \
    --cc=dave.long@linaro.org \
    --cc=dvlasenk@redhat.com \
    --cc=fche@redhat.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mjw@redhat.com \
    --cc=oleg@redhat.com \
    --cc=panand@redhat.com \
    --cc=willeke@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.