From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751497AbbEGTTV (ORCPT ); Thu, 7 May 2015 15:19:21 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37873 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbbEGTTS (ORCPT ); Thu, 7 May 2015 15:19:18 -0400 Date: Thu, 7 May 2015 20:19:09 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@stlinux.com, rtc-linux@googlegroups.com, a.zummo@towertech.it, daniel.lezcano@linaro.org, wim@iguana.be, tglx@linutronix.de, linux@roeck-us.net, linux-watchdog@vger.kernel.org Subject: Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource Message-ID: <20150507191909.GC16220@x1> References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-7-git-send-email-lee.jones@linaro.org> <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt | 15 +++++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > index 388c88a..0b1a784 100644 > > --- a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > @@ -1,20 +1,23 @@ > > STMicroelectronics Low Power Controller (LPC) - Watchdog > > ======================================================== > > > > -LPC currently supports Watchdog OR Real Time Clock functionality. > > +LPC currently supports Watchdog OR Real Time Clock OR Clocksource > > +functionality. > > > > [See: ../rtc/rtc-st-lpc.txt for RTC options] > > +[See: ../timer/st,stih407-lpc for Clocksource options] > > > > Required properties > > > > -- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc" > > - "st,stih415-lpc" "st,stid127-lpc" > > +- compatible : Must be one of: "st,stih407-lpc" > > The same comment as the RTC DT patch, you are removing the compatibles > documentation for the other supported platforms like stih416-lpc. > AFAIK they are required in the driver to get the correct sysconfig register. That's intentional. I haven't yet tested any of this IP on STiH41{5,6} & STiH127. Due to lack of documentation, I'm not even sure if this IP even exists on some of the other platforms. I will add them back when support is added to both driver and DTB and I've been able to test them. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com. [209.85.212.174]) by gmr-mx.google.com with ESMTPS id k2si327824wif.0.2015.05.07.12.19.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2015 12:19:16 -0700 (PDT) Received: by wiun10 with SMTP id n10so3160661wiu.1 for ; Thu, 07 May 2015 12:19:16 -0700 (PDT) Date: Thu, 7 May 2015 20:19:09 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@stlinux.com, rtc-linux@googlegroups.com, a.zummo@towertech.it, daniel.lezcano@linaro.org, wim@iguana.be, tglx@linutronix.de, linux@roeck-us.net, linux-watchdog@vger.kernel.org Subject: [rtc-linux] Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource Message-ID: <20150507191909.GC16220@x1> References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-7-git-send-email-lee.jones@linaro.org> <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , > > Signed-off-by: Lee Jones > > --- > > Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt | 15 +++++++= ++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt = b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > index 388c88a..0b1a784 100644 > > --- a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > @@ -1,20 +1,23 @@ > > STMicroelectronics Low Power Controller (LPC) - Watchdog > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > =20 > > -LPC currently supports Watchdog OR Real Time Clock functionality. > > +LPC currently supports Watchdog OR Real Time Clock OR Clocksource > > +functionality. > > =20 > > [See: ../rtc/rtc-st-lpc.txt for RTC options] > > +[See: ../timer/st,stih407-lpc for Clocksource options] > > =20 > > Required properties > > =20 > > -- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc" > > - "st,stih415-lpc" "st,stid127-lpc" > > +- compatible : Must be one of: "st,stih407-lpc" >=20 > The same comment as the RTC DT patch, you are removing the compatibles > documentation for the other supported platforms like stih416-lpc. > AFAIK they are required in the driver to get the correct sysconfig regist= er. That's intentional. I haven't yet tested any of this IP on STiH41{5,6} & STiH127. Due to lack of documentation, I'm not even sure if this IP even exists on some of the other platforms. I will add them back when support is added to both driver and DTB and I've been able to test them. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource Date: Thu, 7 May 2015 20:19:09 +0100 Message-ID: <20150507191909.GC16220@x1> References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-7-git-send-email-lee.jones@linaro.org> <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Griffin Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt | 15 +++= ++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.= txt b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > index 388c88a..0b1a784 100644 > > --- a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > @@ -1,20 +1,23 @@ > > STMicroelectronics Low Power Controller (LPC) - Watchdog > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > =20 > > -LPC currently supports Watchdog OR Real Time Clock functionality. > > +LPC currently supports Watchdog OR Real Time Clock OR Clocksource > > +functionality. > > =20 > > [See: ../rtc/rtc-st-lpc.txt for RTC options] > > +[See: ../timer/st,stih407-lpc for Clocksource options] > > =20 > > Required properties > > =20 > > -- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc" > > - "st,stih415-lpc" "st,stid127-lpc" > > +- compatible : Must be one of: "st,stih407-lpc" >=20 > The same comment as the RTC DT patch, you are removing the compatible= s > documentation for the other supported platforms like stih416-lpc. > AFAIK they are required in the driver to get the correct sysconfig re= gister. That's intentional. I haven't yet tested any of this IP on STiH41{5,6} & STiH127. Due to lack of documentation, I'm not even sure if this IP even exists on some of the other platforms. I will add them back when support is added to both driver and DTB and I've been able to test them. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:33203 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbbEGTTS (ORCPT ); Thu, 7 May 2015 15:19:18 -0400 Received: by wief7 with SMTP id f7so21047779wie.0 for ; Thu, 07 May 2015 12:19:16 -0700 (PDT) Date: Thu, 7 May 2015 20:19:09 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@stlinux.com, rtc-linux@googlegroups.com, a.zummo@towertech.it, daniel.lezcano@linaro.org, wim@iguana.be, tglx@linutronix.de, linux@roeck-us.net, linux-watchdog@vger.kernel.org Subject: Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource Message-ID: <20150507191909.GC16220@x1> References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-7-git-send-email-lee.jones@linaro.org> <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt | 15 +++= ++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.= txt b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > index 388c88a..0b1a784 100644 > > --- a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > @@ -1,20 +1,23 @@ > > STMicroelectronics Low Power Controller (LPC) - Watchdog > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > =20 > > -LPC currently supports Watchdog OR Real Time Clock functionality. > > +LPC currently supports Watchdog OR Real Time Clock OR Clocksource > > +functionality. > > =20 > > [See: ../rtc/rtc-st-lpc.txt for RTC options] > > +[See: ../timer/st,stih407-lpc for Clocksource options] > > =20 > > Required properties > > =20 > > -- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc" > > - "st,stih415-lpc" "st,stid127-lpc" > > +- compatible : Must be one of: "st,stih407-lpc" >=20 > The same comment as the RTC DT patch, you are removing the compatible= s > documentation for the other supported platforms like stih416-lpc. > AFAIK they are required in the driver to get the correct sysconfig re= gister. That's intentional. I haven't yet tested any of this IP on STiH41{5,6} & STiH127. Due to lack of documentation, I'm not even sure if this IP even exists on some of the other platforms. I will add them back when support is added to both driver and DTB and I've been able to test them. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 7 May 2015 20:19:09 +0100 Subject: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource In-Reply-To: <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-7-git-send-email-lee.jones@linaro.org> <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> Message-ID: <20150507191909.GC16220@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > Signed-off-by: Lee Jones > > --- > > Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt | 15 +++++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > index 388c88a..0b1a784 100644 > > --- a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > @@ -1,20 +1,23 @@ > > STMicroelectronics Low Power Controller (LPC) - Watchdog > > ======================================================== > > > > -LPC currently supports Watchdog OR Real Time Clock functionality. > > +LPC currently supports Watchdog OR Real Time Clock OR Clocksource > > +functionality. > > > > [See: ../rtc/rtc-st-lpc.txt for RTC options] > > +[See: ../timer/st,stih407-lpc for Clocksource options] > > > > Required properties > > > > -- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc" > > - "st,stih415-lpc" "st,stid127-lpc" > > +- compatible : Must be one of: "st,stih407-lpc" > > The same comment as the RTC DT patch, you are removing the compatibles > documentation for the other supported platforms like stih416-lpc. > AFAIK they are required in the driver to get the correct sysconfig register. That's intentional. I haven't yet tested any of this IP on STiH41{5,6} & STiH127. Due to lack of documentation, I'm not even sure if this IP even exists on some of the other platforms. I will add them back when support is added to both driver and DTB and I've been able to test them. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog